Issue 132433005: Use web-based sign-in, rather than inline signin, for v1 and v2 apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132433005: Use web-based sign-in, rather than inline signin, for v1 and v2 apps. (Closed)

Created:
6 years, 11 months ago by anandc

Modified:
6 years, 11 months ago

Reviewers:
weitao, garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use web-based sign-in, rather than inline signin, for v1 and v2 apps. The remoting browser test started failing for the v2 web-app, because authentication now redirects by default to the inline signin flow. To fix this, we enforce web-based sign-in by passing in the required flag. Tested that existing MANUAL_Me2Me_Connect_Local_Host, which was passing for the v1 web-app and failing for the v2 web-app, now passes for both with this change. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244103