Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132423002: Remove references to Skia's SVN repository (Closed)

Created:
6 years, 11 months ago by borenet
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove references to Skia's SVN repository BUG= R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=13006

Patch Set 1 #

Total comments: 11

Patch Set 2 : trunk->skia #

Total comments: 5

Patch Set 3 : Undo changes to view.html and view-platform.html #

Patch Set 4 : Re-change first link in view.html and view-platform.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -104 lines) Patch
M bench/bench_analyze.py View 1 chunk +4 lines, -4 lines 0 comments Download
M expectations/gm/view-platform.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gm/rebaseline_server/static/view.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M platform_tools/android/gclient.config View 1 chunk +2 lines, -2 lines 0 comments Download
D platform_tools/nacl/gclient.config View 1 chunk +0 lines, -13 lines 0 comments Download
D tools/build-tot-chromium.sh View 1 chunk +0 lines, -59 lines 0 comments Download
M tools/buildbot_globals.py View 3 chunks +47 lines, -5 lines 0 comments Download
M tools/submit_try View 2 chunks +8 lines, -13 lines 0 comments Download
M tools/update-doxygen.sh View 1 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
borenet
https://codereview.chromium.org/132423002/diff/1/bench/bench_analyze.py File bench/bench_analyze.py (right): https://codereview.chromium.org/132423002/diff/1/bench/bench_analyze.py#newcode1 bench/bench_analyze.py:1: #!/usr/bin/env python Ben, I've changed this URL to point ...
6 years, 11 months ago (2014-01-09 19:27:28 UTC) #1
mtklein
https://codereview.chromium.org/132423002/diff/1/platform_tools/android/gclient.config File platform_tools/android/gclient.config (right): https://codereview.chromium.org/132423002/diff/1/platform_tools/android/gclient.config#newcode1 platform_tools/android/gclient.config:1: # To develop Skia targeting Android, On 2014/01/09 19:27:28, ...
6 years, 11 months ago (2014-01-09 19:44:58 UTC) #2
epoger
LGTM, with some minor suggestions https://codereview.chromium.org/132423002/diff/30001/expectations/gm/view-platform.html File expectations/gm/view-platform.html (right): https://codereview.chromium.org/132423002/diff/30001/expectations/gm/view-platform.html#newcode147 expectations/gm/view-platform.html:147: I tried importing the ...
6 years, 11 months ago (2014-01-09 19:48:35 UTC) #3
borenet
https://codereview.chromium.org/132423002/diff/1/platform_tools/android/gclient.config File platform_tools/android/gclient.config (right): https://codereview.chromium.org/132423002/diff/1/platform_tools/android/gclient.config#newcode1 platform_tools/android/gclient.config:1: # To develop Skia targeting Android, On 2014/01/09 19:44:59, ...
6 years, 11 months ago (2014-01-09 20:05:58 UTC) #4
borenet
Uploaded patch set 4.
6 years, 11 months ago (2014-01-09 20:18:06 UTC) #5
epoger
lgtm
6 years, 11 months ago (2014-01-09 20:25:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/132423002/170001
6 years, 11 months ago (2014-01-09 20:26:48 UTC) #7
borenet
6 years, 11 months ago (2014-01-09 21:41:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 manually as r13006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698