chrome/android/java/AndroidManifest.xml - Issue 1324173002: [Background Sync] Use GcmNetworkManager to start the browser for sync events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/AndroidManifest.xml

Issue 1324173002: [Background Sync] Use GcmNetworkManager to start the browser for sync events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@bgsync-fix-background5

Patch Set: Add VisibleForTesting annotation to overridden methods in BSLS Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/BUILD.gn ('K') | « chrome/android/BUILD.gn ('k') | chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/AndroidManifest.xml

diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml

index 6c0891e675b93a11f307cd5db3c6fc9734f0305d..7d15a3b36a4d5f23649672b726fc9568e12f845b 100644

--- a/chrome/android/java/AndroidManifest.xml

+++ b/chrome/android/java/AndroidManifest.xml

@@ -45,6 +45,7 @@ by a child template that "extends" this file.

<uses-permission android:name="android.permission.NFC"/>

<uses-permission android:name="android.permission.READ_SYNC_SETTINGS"/>

<uses-permission android:name="android.permission.READ_SYNC_STATS"/>

+ <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/>

Yaron 2015/10/15 22:18:22 Can you also mention the new permission in descrip

iclelland 2015/10/16 14:52:34 Done.

<uses-permission android:name="android.permission.RECORD_AUDIO"/>

<uses-permission android:name="android.permission.USE_CREDENTIALS"/>

<uses-permission android:name="android.permission.VIBRATE"/>

@@ -557,14 +558,14 @@ by a child template that "extends" this file.

</intent-filter>

</receiver>

-

- <service android:name="org.chromium.content.browser.BackgroundSyncLauncherService"

- android:exported="false" />

- <receiver android:name="org.chromium.content.browser.BackgroundSyncLauncherService$Receiver">

+

+ <service android:name="org.chromium.chrome.browser.BackgroundSyncLauncherService"

+ android:permission="com.google.android.gms.permission.BIND_NETWORK_TASK_SERVICE"

+ android:exported="true">

<intent-filter>

- <action android:name="android.net.conn.CONNECTIVITY_CHANGE" />

+ <action android:name="com.google.android.gms.gcm.ACTION_TASK_READY" />

</intent-filter>

- </receiver>

+ </service>

<service android:name="org.chromium.chrome.browser.prerender.ChromePrerenderService"

android:exported="true"