Add template parameter and unittests to atomic utils.

Add template parameter and unittests to atomic utils.

BUG=

Committed: https://crrev.com/cd6631ade91f16370588954c7ccd435544e911f2
Cr-Commit-Position: refs/heads/master@{#30589}

[Michael Lippautz, 2015-09-04 11:09:32]

The changes we discussed and the unittests you didn't ask for :)

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h
File src/atomic-utils.h (right):

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newc...
src/atomic-utils.h:16: template <class T>
I don't think we need the storage type, as it should always be an AtomicWord.

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newc...
src/atomic-utils.h:89: void Remove(E element) { ATOMIC_SET_WRITE(&,
~Mask(element)); }
*duck*

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newc...
src/atomic-utils.h:119: class AtomicFlag {
Maybe another name would fit better.

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newc...
src/atomic-utils.h:126: return (T)(base::NoBarrier_Load(&value_));
This is a bit unfortunate but I think AtomicFlag<void*> could be useful.

[Michael Lippautz, 2015-09-04 11:10:00]

mlippautz@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Lippautz, 2015-09-04 11:10:00]

(message see above; finger was faster than brain)

[Michael Starzinger, 2015-09-04 11:43:19]

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h
File src/atomic-utils.h (right):

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newc...
src/atomic-utils.h:119: class AtomicFlag {
On 2015/09/04 11:09:32, Michael Lippautz wrote:
> Maybe another name would fit better.

Yeah, the name is misleading. How about "AtomicVariable", or "AtomicState"?

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newc...
src/atomic-utils.h:126: return (T)(base::NoBarrier_Load(&value_));
On 2015/09/04 11:09:32, Michael Lippautz wrote:
> This is a bit unfortunate but I think AtomicFlag<void*> could be useful.

This is uncool. Need to think more about that.

[Michael Lippautz, 2015-09-04 13:03:52]

PTAL

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h
File src/atomic-utils.h (right):

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newc...
src/atomic-utils.h:17: class AtomicValue {
This one is now AtomicNumber

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newc...
src/atomic-utils.h:119: class AtomicFlag {
On 2015/09/04 11:43:19, Michael Starzinger wrote:
> On 2015/09/04 11:09:32, Michael Lippautz wrote:
> > Maybe another name would fit better.
> 
> Yeah, the name is misleading. How about "AtomicVariable", or "AtomicState"?

AtomicValue it is.

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newc...
src/atomic-utils.h:126: return (T)(base::NoBarrier_Load(&value_));
On 2015/09/04 11:43:19, Michael Starzinger wrote:
> On 2015/09/04 11:09:32, Michael Lippautz wrote:
> > This is a bit unfortunate but I think AtomicFlag<void*> could be useful.
> 
> This is uncool. Need to think more about that.

See the new "solution" (I know this is the wrong word...).

[Michael Starzinger, 2015-09-04 13:28:46]

LGTM.

https://codereview.chromium.org/1324153003/diff/10005/src/atomic-utils.h
File src/atomic-utils.h (right):

https://codereview.chromium.org/1324153003/diff/10005/src/atomic-utils.h#newc...
src/atomic-utils.h:67: struct cast_helper {
Got a rhyme for you:

You sneaky C++ wiz,
I am fine with this.
But my C++ foo isn't strong,
so I might just be wrong.

[Michael Lippautz, 2015-09-04 13:36:43]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2015-09-04 13:36:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324153003/10005
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324153003/10005

[Michael Lippautz, 2015-09-04 13:37:12]

https://codereview.chromium.org/1324153003/diff/10005/src/atomic-utils.h
File src/atomic-utils.h (right):

https://codereview.chromium.org/1324153003/diff/10005/src/atomic-utils.h#newc...
src/atomic-utils.h:67: struct cast_helper {
On 2015/09/04 13:28:46, Michael Starzinger wrote:
> Got a rhyme for you:
> 
> You sneaky C++ wiz,
> I am fine with this.
> But my C++ foo isn't strong,
> so I might just be wrong.

Hah! Good enough for me!

[commit-bot: I haz the power, 2015-09-04 14:02:18]

Committed patchset #3 (id:10005)

[commit-bot: I haz the power, 2015-09-04 14:02:27]

Patchset 3 (id:??) landed as
https://crrev.com/cd6631ade91f16370588954c7ccd435544e911f2
Cr-Commit-Position: refs/heads/master@{#30589}