Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1324133002: Make XPathFunction map use non-static table of FunctionMapping (Closed)

Created:
5 years, 3 months ago by vivekg_samsung
Modified:
5 years, 3 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make XPathFunction map use non-static table of FunctionMapping The functionMap is already a global static variable. The createFunction has a check which makes the method createFunction being called only once. Hence there is no need of this function table to be a static table. This reduces the bss size on linux by 656 bytes R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201638

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/xml/XPathFunctions.cpp View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324133002/1
5 years, 3 months ago (2015-09-02 10:10:50 UTC) #2
vivekg
PTAL, thanks.
5 years, 3 months ago (2015-09-02 10:11:42 UTC) #4
vivekg
https://codereview.chromium.org/1324133002/diff/1/Source/core/xml/XPathFunctions.cpp File Source/core/xml/XPathFunctions.cpp (right): https://codereview.chromium.org/1324133002/diff/1/Source/core/xml/XPathFunctions.cpp#newcode755 Source/core/xml/XPathFunctions.cpp:755: if (!functionMap) The check here makes sure the function ...
5 years, 3 months ago (2015-09-02 10:15:40 UTC) #5
vivekg
Before and after: text data bss dec hex filename 38578 1976 696 41250 a122 webcore_shared.XPathFunctions.o ...
5 years, 3 months ago (2015-09-02 10:44:05 UTC) #6
haraken
LGTM
5 years, 3 months ago (2015-09-02 10:52:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324133002/1
5 years, 3 months ago (2015-09-02 11:48:16 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 12:22:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201638

Powered by Google App Engine
This is Rietveld 408576698