Issue 132413002: Just use one version of the scripts in both the browser and in SkV8.

Issue 132413002: Just use one version of the scripts in both the browser and in SkV8. (Closed)

Created:
6 years, 11 months ago by jcgregorio

Modified:
6 years, 11 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Just use one version of the scripts in both the browser and in SkV8 by using feature detection to determine if we are running in a browser, and if the platform supports the Path() object. Also add oval, console.log, and the snow example code. BUG= Committed: http://code.google.com/p/skia/source/detail?r=13031

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix indent #

Patch Set 3 : merge #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+231 lines, -126 lines)			Patch
M	experimental/SkV8Example/Path.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	experimental/SkV8Example/Path.cpp	View	1 2	2 chunks	+28 lines, -1 line	0 comments	Download
M	experimental/SkV8Example/SkV8Example.cpp	View	1	2 chunks	+22 lines, -5 lines	0 comments	Download
M	experimental/SkV8Example/compare/gears.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	experimental/SkV8Example/compare/gears.js	View		1 chunk	+0 lines, -93 lines	0 comments	Download
A	experimental/SkV8Example/compare/snow.html	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	experimental/SkV8Example/gears.js	View		4 chunks	+75 lines, -25 lines	0 comments	Download
A	experimental/SkV8Example/snow.js	View		1 chunk	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 nit https://codereview.chromium.org/132413002/diff/1/experimental/SkV8Example/SkV8Example.cpp File experimental/SkV8Example/SkV8Example.cpp (right): https://codereview.chromium.org/132413002/diff/1/experimental/SkV8Example/SkV8Example.cpp#newcode162 experimental/SkV8Example/SkV8Example.cpp:162: const char* startupScript = can ...

6 years, 11 months ago (2014-01-10 20:54:34 UTC) #2

jcgregorio

https://codereview.chromium.org/132413002/diff/1/experimental/SkV8Example/SkV8Example.cpp File experimental/SkV8Example/SkV8Example.cpp (right): https://codereview.chromium.org/132413002/diff/1/experimental/SkV8Example/SkV8Example.cpp#newcode162 experimental/SkV8Example/SkV8Example.cpp:162: const char* startupScript = Done. Also done for below. ...

6 years, 11 months ago (2014-01-10 20:57:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/132413002/50001

6 years, 11 months ago (2014-01-10 20:58:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/132413002/140001

6 years, 11 months ago (2014-01-10 21:24:46 UTC) #5

Message was sent while issue was closed.

Change committed as 13031

Expand Messages | Collapse Messages