Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1324123003: Introduce composed tree version of startOfDocument() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of startOfDocument() This patch introduces composed tree version of |startOfDocument()| by templatizing original |startOfDocument()| to work both DOM tree position and composed tree position version for introducing composed tree version of |VisibleSelection| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201979

Patch Set 1 : 2015-09-09T17:24:38 #

Patch Set 2 : 2015-09-09T22:19:30 Rebase for VisibleUnitsTest.cpp conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M Source/core/editing/VisibleUnits.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 1 chunk +11 lines, -4 lines 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-09 09:17:56 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-09-09 10:54:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324123003/1
5 years, 3 months ago (2015-09-09 10:55:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/67047) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-09 10:57:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324123003/1
5 years, 3 months ago (2015-09-09 11:06:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/67051)
5 years, 3 months ago (2015-09-09 11:08:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324123003/20001
5 years, 3 months ago (2015-09-09 13:20:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/30141)
5 years, 3 months ago (2015-09-09 13:48:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324123003/20001
5 years, 3 months ago (2015-09-09 13:54:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/30157)
5 years, 3 months ago (2015-09-09 14:20:23 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324123003/20001
5 years, 3 months ago (2015-09-09 14:24:30 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 14:53:41 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201979

Powered by Google App Engine
This is Rietveld 408576698