Adding js2c.py "Too many arguments" for Macros Error

Adding js2c.py "Too many arguments" for Macros Error

BUG=

Committed: https://crrev.com/73cb8c7774e036954353a20ba479d9d4386b2c30
Cr-Commit-Position: refs/heads/master@{#30620}

[Camillo Bruni, 2015-09-07 07:46:11]

cbruni@chromium.org changed reviewers:
+ machenbach@chromium.org

[Camillo Bruni, 2015-09-07 07:46:12]

PTAL

[Michael Achenbach, 2015-09-07 13:02:17]

lgtm with suggestion

https://codereview.chromium.org/1324103003/diff/40001/tools/js2c.py
File tools/js2c.py (right):

https://codereview.chromium.org/1324103003/diff/40001/tools/js2c.py#newcode112
tools/js2c.py:112: lineno = lines.count("\n", 0, start) + 1
Does counting \n lead to a good result on windows? Is this equivalent to the
following?
len(lines[0:start-1].splitlines())

[Camillo Bruni, 2015-09-07 13:16:26]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-09-07 13:16:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1324103003/#ps60001
(title: "use os.linesep")

[commit-bot: I haz the power, 2015-09-07 13:16:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324103003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324103003/60001

[commit-bot: I haz the power, 2015-09-07 14:03:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-07 14:04:15]

Patchset 4 (id:??) landed as
https://crrev.com/73cb8c7774e036954353a20ba479d9d4386b2c30
Cr-Commit-Position: refs/heads/master@{#30620}