Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1324093005: MIPS64: Fix 'On a call to Array(), we patched a call ic.' (Closed)

Created:
5 years, 3 months ago by balazs.kilvady
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix 'On a call to Array(), we patched a call ic.' Port ba7b64139886ab7987406a92bf0e801b807c9fe4 Original commit message: This CL makes do with a single dispatcher which inlines the special handling for the Array() call case, loading the allocation site found in the vector and calling the array constructor stub appropriately. BUG= Committed: https://crrev.com/da830b0eaa809739e5d76887858977b108f90abd Cr-Commit-Position: refs/heads/master@{#30653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/mips64/code-stubs-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 3 months ago (2015-09-09 12:59:40 UTC) #2
mvstanton
LGTM - thank you!
5 years, 3 months ago (2015-09-09 13:00:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324093005/1
5 years, 3 months ago (2015-09-09 13:32:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 13:57:57 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 13:58:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da830b0eaa809739e5d76887858977b108f90abd
Cr-Commit-Position: refs/heads/master@{#30653}

Powered by Google App Engine
This is Rietveld 408576698