Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1324083002: Fix a mouse lock problem on Windows where in clicks outside the web page would also cause mouse loc… (Closed)

Created:
5 years, 3 months ago by ananta
Modified:
5 years, 3 months ago
Reviewers:
scheib, jam, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a mouse lock problem on Windows where in clicks outside the web page would also cause mouse lock to happen. This fixes an issue with the mouse locking code on Windows where in if a page entered a mouse lock state and exited it via the Esc key, subsequently clicking outside the page would cause the lock prompt to display again. This was because RenderWidgetHostViewAura grabs capture on all platforms including Windows. On Windows the capture happens elsewhere in the mouse handler. However when the mouse release comes in it is possible that we are already in the mouse locked state and hence the capture is never released. Fix is to release capture on all platforms. BUG=526378 R=scheib TBR=jam Committed: https://crrev.com/c922b25f080de27ebe891adff689e9b56ffeaf12 Cr-Commit-Position: refs/heads/master@{#347122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
ananta
5 years, 3 months ago (2015-09-02 02:12:28 UTC) #1
scheib
LGTM
5 years, 3 months ago (2015-09-02 15:28:12 UTC) #2
ananta
+sky for content renderer host owner review
5 years, 3 months ago (2015-09-02 23:15:33 UTC) #4
sky
LGTM
5 years, 3 months ago (2015-09-02 23:56:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324083002/1
5 years, 3 months ago (2015-09-03 00:31:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/95967)
5 years, 3 months ago (2015-09-03 00:51:22 UTC) #11
ananta
TBR'ing jam for content owners.
5 years, 3 months ago (2015-09-03 06:00:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324083002/1
5 years, 3 months ago (2015-09-03 06:01:23 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 06:43:19 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 06:44:01 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c922b25f080de27ebe891adff689e9b56ffeaf12
Cr-Commit-Position: refs/heads/master@{#347122}

Powered by Google App Engine
This is Rietveld 408576698