Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: mojo/common/dart/lib/tracing_helper.dart

Issue 1324063005: Fix tid recorded in dart tracing helper to be an integer. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address Ben's comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/dart/lib/tracing_helper.dart
diff --git a/mojo/common/dart/lib/tracing_helper.dart b/mojo/common/dart/lib/tracing_helper.dart
index ebe45a9a724be93d5cee7e05295700fc91e1e12c..21e6b5606151290fd3c19cfa2cf841c5bc2a4ed6 100644
--- a/mojo/common/dart/lib/tracing_helper.dart
+++ b/mojo/common/dart/lib/tracing_helper.dart
@@ -21,7 +21,7 @@ import 'package:mojo_services/tracing/tracing.mojom.dart';
// to perform tracing.
class TracingHelper {
TraceProviderImpl _impl;
- String _tid;
+ int _tid;
// Construct an instance of TracingHelper from within your application's
// |initialize()| method. |appName| will be used to form a thread identifier
@@ -34,7 +34,7 @@ class TracingHelper {
if (appName.length > 20) {
appName = appName.substring(appName.length - 20);
}
- _tid = "${appName}/${Isolate.current.hashCode.toString()}";
+ _tid = appName.hashCode ^ Isolate.current.hashCode;
ApplicationConnection connection = app.connectToApplication("mojo:tracing");
connection.provideService(TraceProviderName, (e) {
assert(_impl == null);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698