Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1324063005: Fix tid recorded in dart tracing helper to be an integer. (Closed)

Created:
5 years, 3 months ago by ppi
Modified:
5 years, 3 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix tid recorded in dart tracing helper to be an integer. Trace Event format spec requires tid to be integers, not strings. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/07c0149c5c3ac1b63c9810a2b5a6867c9b8513f8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/common/dart/lib/tracing_helper.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ppi
Hi Ben, ptal.
5 years, 3 months ago (2015-09-07 18:21:00 UTC) #2
qsr
https://codereview.chromium.org/1324063005/diff/1/mojo/common/dart/lib/tracing_helper.dart File mojo/common/dart/lib/tracing_helper.dart (right): https://codereview.chromium.org/1324063005/diff/1/mojo/common/dart/lib/tracing_helper.dart#newcode37 mojo/common/dart/lib/tracing_helper.dart:37: _tid = Isolate.current.hashCode; Can you mix the hashCode of ...
5 years, 3 months ago (2015-09-08 12:38:54 UTC) #3
ppi
https://codereview.chromium.org/1324063005/diff/1/mojo/common/dart/lib/tracing_helper.dart File mojo/common/dart/lib/tracing_helper.dart (right): https://codereview.chromium.org/1324063005/diff/1/mojo/common/dart/lib/tracing_helper.dart#newcode37 mojo/common/dart/lib/tracing_helper.dart:37: _tid = Isolate.current.hashCode; On 2015/09/08 12:38:54, qsr wrote: > ...
5 years, 3 months ago (2015-09-08 16:42:49 UTC) #5
ppi
https://codereview.chromium.org/1324063005/diff/1/mojo/common/dart/lib/tracing_helper.dart File mojo/common/dart/lib/tracing_helper.dart (right): https://codereview.chromium.org/1324063005/diff/1/mojo/common/dart/lib/tracing_helper.dart#newcode37 mojo/common/dart/lib/tracing_helper.dart:37: _tid = Isolate.current.hashCode; On 2015/09/08 12:38:54, qsr wrote: > ...
5 years, 3 months ago (2015-09-08 16:42:50 UTC) #6
qsr
lgtm
5 years, 3 months ago (2015-09-09 08:55:21 UTC) #7
ppi
5 years, 3 months ago (2015-09-09 09:28:22 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
07c0149c5c3ac1b63c9810a2b5a6867c9b8513f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698