Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: pkg/template_binding/lib/src/select_element.dart

Issue 132403010: big update to observe, template_binding, polymer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/template_binding/lib/src/node_binding.dart ('k') | pkg/template_binding/lib/src/template.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/template_binding/lib/src/select_element.dart
diff --git a/pkg/template_binding/lib/src/select_element.dart b/pkg/template_binding/lib/src/select_element.dart
index 432b0490b68ee47822a03b9800c31ec010ebf93c..f205a15cf20a85cf254d2d0e01220fd0184c510a 100644
--- a/pkg/template_binding/lib/src/select_element.dart
+++ b/pkg/template_binding/lib/src/select_element.dart
@@ -10,14 +10,21 @@ class _SelectElementExtension extends _ElementExtension {
SelectElement get _node => super._node;
- NodeBinding bind(String name, model, [String path]) {
+ Bindable bind(String name, value, {bool oneTime: false}) {
if (name == 'selectedindex') name = 'selectedIndex';
if (name != 'selectedIndex' && name != 'value') {
- return super.bind(name, model, path);
+ return super.bind(name, value, oneTime: oneTime);
}
- _self.unbind(name);
+ // TODO(jmesserly): merge logic here with InputElement, it's the same except
+ // for the addition of selectedIndex as a valid property name.
_node.attributes.remove(name);
- return bindings[name] = new _SelectBinding(_node, name, model, path);
+ if (oneTime) {
+ _InputBinding._updateProperty(_node, value, name);
+ return null;
+ }
+
+ _self.unbind(name);
+ return bindings[name] = new _InputBinding(_node, value, name);
}
}
« no previous file with comments | « pkg/template_binding/lib/src/node_binding.dart ('k') | pkg/template_binding/lib/src/template.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698