Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 132403008: Remove unnamed namespace usage from tests/ (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove unnamed namespace usage from tests/ Skia preference is to use 'static' keyword rather than use unnamed namespace. BUG=None TEST=tests R=robertphillips@google.com, bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=13138

Patch Set 1 #

Patch Set 2 : * with type #

Patch Set 3 : #

Total comments: 18

Patch Set 4 : review #

Patch Set 5 : SK_OVERRIDE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -145 lines) Patch
M tests/CachedDecodingPixelRefTest.cpp View 1 2 3 7 chunks +34 lines, -38 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
M tests/GifTest.cpp View 1 2 3 2 chunks +48 lines, -55 lines 0 comments Download
M tests/ImageDecodingTest.cpp View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
M tests/PixelRefTest.cpp View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M tests/Test.cpp View 1 2 3 2 chunks +35 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Hi Brian, Robert, can I get a review from either of you? Thank you!
6 years, 11 months ago (2014-01-14 01:55:14 UTC) #1
robertphillips
lgtm + a bunch of nits https://codereview.chromium.org/132403008/diff/100001/tests/CachedDecodingPixelRefTest.cpp File tests/CachedDecodingPixelRefTest.cpp (right): https://codereview.chromium.org/132403008/diff/100001/tests/CachedDecodingPixelRefTest.cpp#newcode184 tests/CachedDecodingPixelRefTest.cpp:184: } virtual? https://codereview.chromium.org/132403008/diff/100001/tests/CachedDecodingPixelRefTest.cpp#newcode185 ...
6 years, 11 months ago (2014-01-14 13:19:37 UTC) #2
tfarina
Robert, in respect to the time you spent reviewing this... https://codereview.chromium.org/132403008/diff/100001/tests/CachedDecodingPixelRefTest.cpp File tests/CachedDecodingPixelRefTest.cpp (right): https://codereview.chromium.org/132403008/diff/100001/tests/CachedDecodingPixelRefTest.cpp#newcode184 ...
6 years, 11 months ago (2014-01-21 23:37:43 UTC) #3
tfarina
6 years, 11 months ago (2014-01-21 23:39:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r13138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698