Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: src/objects.cc

Issue 1324023007: [heap] introduce ArrayBufferTracker (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: split out Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 8caa732ba6c39981dff49dcbe4f4c591ebd544dc..35a5e079d8abf70c8257c2645d773d66c851ea7d 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -27,6 +27,7 @@
#include "src/field-index-inl.h"
#include "src/field-index.h"
#include "src/full-codegen/full-codegen.h"
+#include "src/heap/array-buffer-tracker.h"
Michael Lippautz 2015/09/04 08:24:15 Only include src/heap/heap.h
fedor.indutny 2015/09/04 08:58:05 Acknowledged, doesn't look like it is needed.
#include "src/hydrogen.h"
#include "src/ic/ic.h"
#include "src/interpreter/bytecodes.h"
@@ -15943,7 +15944,7 @@ void JSArrayBuffer::Setup(Handle<JSArrayBuffer> array_buffer, Isolate* isolate,
array_buffer->set_is_shared(shared == SharedFlag::kShared);
if (data && !is_external) {
- isolate->heap()->RegisterNewArrayBuffer(
+ isolate->heap()->array_buffer_tracker()->RegisterNew(
Michael Lippautz 2015/09/04 08:24:15 Use the wrapper call for Register.
fedor.indutny 2015/09/04 08:58:05 Acknowledged.
isolate->heap()->InNewSpace(*array_buffer), data, allocated_length);
}
@@ -15998,9 +15999,9 @@ Handle<JSArrayBuffer> JSTypedArray::MaterializeArrayBuffer(
fixed_typed_array->DataSize());
buffer->set_backing_store(backing_store);
buffer->set_is_external(false);
- isolate->heap()->RegisterNewArrayBuffer(isolate->heap()->InNewSpace(*buffer),
- backing_store,
- fixed_typed_array->DataSize());
+ isolate->heap()->array_buffer_tracker()->RegisterNew(
Michael Lippautz 2015/09/04 08:24:15 Ditto.
fedor.indutny 2015/09/04 08:58:05 Acknowledged.
+ isolate->heap()->InNewSpace(*buffer), backing_store,
+ fixed_typed_array->DataSize());
memcpy(buffer->backing_store(),
fixed_typed_array->DataPtr(),
fixed_typed_array->DataSize());

Powered by Google App Engine
This is Rietveld 408576698