Remove migrateNetworkPredictionPreferences().

Remove migrateNetworkPredictionPreferences().

Remove predictive network action preference migration code on Android after one
year.  This includes migrateNetworkPredictionPreferences(), string constants for
preferences, and JNI accessors.

BUG=526773
Committed: https://crrev.com/2eab6589a52b9773f6c0294b69beef35ed4c7bf0
Cr-Commit-Position: refs/heads/master@{#346898}

[Bence, 2015-09-01 14:58:52]

bnc@chromium.org changed reviewers:
+ newt@chromium.org

[Bence, 2015-09-01 14:58:53]

Newton: PTAL.  Thanks.

[newt (away), 2015-09-01 18:44:39]

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
(left):

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java:121:
BandwidthType prefetchBandwidthTypePref = BandwidthType.getBandwidthFromTitle(
Also delete BandwidthType.java.

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
(right):

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java:27:
private static final String PREF_NETWORK_PREDICTIONS = "network_predictions";
also delete PREF_NETWORK_PREDICTIONS?

https://codereview.chromium.org/1323993002/diff/1/chrome/browser/android/pref...
File chrome/browser/android/preferences/pref_service_bridge.cc (left):

https://codereview.chromium.org/1323993002/diff/1/chrome/browser/android/pref...
chrome/browser/android/preferences/pref_service_bridge.cc:729:
prefs::kNetworkPredictionEnabled) != NULL;
Is kNetworkPredictionEnabled still used on other platforms? Can it be removed?

[Bence, 2015-09-01 20:39:59]

PTAL.  Thanks.

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
(left):

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java:121:
BandwidthType prefetchBandwidthTypePref = BandwidthType.getBandwidthFromTitle(
On 2015/09/01 18:44:39, newt wrote:
> Also delete BandwidthType.java.

Done.

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
(right):

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java:27:
private static final String PREF_NETWORK_PREDICTIONS = "network_predictions";
On 2015/09/01 18:44:39, newt wrote:
> also delete PREF_NETWORK_PREDICTIONS?

My understanding is that this is the new preference (the one the migration
routine sets if it wasn't set), and is still used in 
org.chromium.chrome.browser.preferences.privacy.PrivacyPreferences.onCreate and
org.chromium.chrome.browser.preferences.privacy.PrivacyPreferences.onPreferenceChange,
so it should not be deleted.

https://codereview.chromium.org/1323993002/diff/1/chrome/browser/android/pref...
File chrome/browser/android/preferences/pref_service_bridge.cc (left):

https://codereview.chromium.org/1323993002/diff/1/chrome/browser/android/pref...
chrome/browser/android/preferences/pref_service_bridge.cc:729:
prefs::kNetworkPredictionEnabled) != NULL;
On 2015/09/01 18:44:39, newt wrote:
> Is kNetworkPredictionEnabled still used on other platforms? Can it be removed?

Yes, it is still used on other platforms.  It will be removed in the follow-up
CL https://crrev.com/1320613006, which currently does not build exactly because
it removes kNetworkPredictionEnabled but does not touch the Android-specific
part.

[newt (away), 2015-09-01 21:24:21]

lgtm after comment.

Thanks!

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
(right):

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java:27:
private static final String PREF_NETWORK_PREDICTIONS = "network_predictions";
On 2015/09/01 20:39:59, Bence wrote:
> On 2015/09/01 18:44:39, newt wrote:
> > also delete PREF_NETWORK_PREDICTIONS?
> 
> My understanding is that this is the new preference (the one the migration
> routine sets if it wasn't set), and is still used in 
> org.chromium.chrome.browser.preferences.privacy.PrivacyPreferences.onCreate
and
>
org.chromium.chrome.browser.preferences.privacy.PrivacyPreferences.onPreferenceChange,
> so it should not be deleted.

Ah, right. Still, this constant can be removed as it's now unused.

[Bence, 2015-09-02 12:31:38]

The CQ bit was checked by bnc@chromium.org

[Bence, 2015-09-02 12:31:38]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1323993002/#ps40001
(title: "Remove PREF_NETWORK_PREDICTIONS.")

[Bence, 2015-09-02 12:31:44]

Thank you.

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
(right):

https://codereview.chromium.org/1323993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java:27:
private static final String PREF_NETWORK_PREDICTIONS = "network_predictions";
On 2015/09/01 21:24:21, newt wrote:
> On 2015/09/01 20:39:59, Bence wrote:
> > On 2015/09/01 18:44:39, newt wrote:
> > > also delete PREF_NETWORK_PREDICTIONS?
> > 
> > My understanding is that this is the new preference (the one the migration
> > routine sets if it wasn't set), and is still used in 
> > org.chromium.chrome.browser.preferences.privacy.PrivacyPreferences.onCreate
> and
> >
>
org.chromium.chrome.browser.preferences.privacy.PrivacyPreferences.onPreferenceChange,
> > so it should not be deleted.
> 
> Ah, right. Still, this constant can be removed as it's now unused.

Done.  Sorry, I didn't realize this definition is class scope, and it is defined
elsewhere for other user.  My apologies.

[commit-bot: I haz the power, 2015-09-02 12:31:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323993002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323993002/40001

[commit-bot: I haz the power, 2015-09-02 12:36:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-02 12:36:54]

Patchset 3 (id:??) landed as
https://crrev.com/2eab6589a52b9773f6c0294b69beef35ed4c7bf0
Cr-Commit-Position: refs/heads/master@{#346898}

[Yaron, 2015-12-07 20:00:31]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2015-12-07 20:00:32]

https://codereview.chromium.org/1323993002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
(left):

https://codereview.chromium.org/1323993002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java:91:
// Nothing to do if the user or this migration code has already set the new
On second thought (I know I reviewed this addition originally) but the fact that
we're still hitting a ClassCastException here seems problematic.

In particular, we still have an XML file with key network_predictions that tries
reading this as a string so if we don't clear it b/c of early-out we still crash

[Yaron, 2015-12-07 20:06:56]

https://codereview.chromium.org/1323993002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
(left):

https://codereview.chromium.org/1323993002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java:91:
// Nothing to do if the user or this migration code has already set the new
On 2015/12/07 20:00:31, Yaron wrote:
> On second thought (I know I reviewed this addition originally) but the fact
that
> we're still hitting a ClassCastException here seems problematic.
> 
> In particular, we still have an XML file with key network_predictions that
tries
> reading this as a string so if we don't clear it b/c of early-out we still
crash

Err nvm - I see the negation. Regardless, per bugs, it seems like we're not
ready for this removal

[Bence, 2015-12-07 21:46:30]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1505963002/ by bnc@chromium.org.

The reason for reverting is: Causing lots of crashes with ClassCastException..