Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1323973002: Have 'adb' as the default value for when adb_path is not specified (Closed)

Created:
5 years, 3 months ago by etiennej
Modified:
5 years, 3 months ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Have 'adb' as the default value for when adb_path is not specified. This prevents an AttributeError in AndroidShell when no adb_path is specified on the command line. Fixes domokit/devtools#33 R=ppi@chromium.org, ppi Committed: https://chromium.googlesource.com/external/mojo/+/a6b862ed82a1a1d34d1f073e942e6a6964baf696

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/devtools/common/devtoolslib/shell_config.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
etiennej
5 years, 3 months ago (2015-09-01 12:05:29 UTC) #1
ppi
There's gotcha here - command line option beats any defaults inferred later, so we'd use ...
5 years, 3 months ago (2015-09-01 12:08:34 UTC) #2
etiennej
On 2015/09/01 12:08:34, ppi wrote: > There's gotcha here - command line option beats any ...
5 years, 3 months ago (2015-09-01 12:26:39 UTC) #3
ppi
lgtm
5 years, 3 months ago (2015-09-01 12:28:09 UTC) #4
etiennej
5 years, 3 months ago (2015-09-01 12:28:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a6b862ed82a1a1d34d1f073e942e6a6964baf696 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698