Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1323963003: Make GrProcessorDataManager a noop (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -85 lines) Patch
M include/gpu/GrPaint.h View 3 chunks +3 lines, -4 lines 0 comments Download
M include/gpu/GrProcessorDataManager.h View 1 chunk +2 lines, -41 lines 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +9 lines, -10 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 6 chunks +9 lines, -12 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
joshualitt
ptal
5 years, 3 months ago (2015-09-01 15:02:20 UTC) #2
robertphillips
lgtm
5 years, 3 months ago (2015-09-01 15:13:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323963003/1
5 years, 3 months ago (2015-09-01 15:13:39 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 15:19:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323963003/1
5 years, 3 months ago (2015-09-01 15:19:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2316)
5 years, 3 months ago (2015-09-01 15:20:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323963003/1
5 years, 3 months ago (2015-09-09 16:27:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3078)
5 years, 3 months ago (2015-09-09 16:31:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323963003/1
5 years, 3 months ago (2015-09-09 16:55:09 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 17:00:16 UTC) #18
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/af2533a165ae99f79416b730910731768b0a4ddf

Powered by Google App Engine
This is Rietveld 408576698