Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: pdf/out_of_process_instance.h

Issue 1323943011: Fix memory leak of PreviewModeClient in PDF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pdf/out_of_process_instance.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PDF_OUT_OF_PROCESS_INSTANCE_H_ 5 #ifndef PDF_OUT_OF_PROCESS_INSTANCE_H_
6 #define PDF_OUT_OF_PROCESS_INSTANCE_H_ 6 #define PDF_OUT_OF_PROCESS_INSTANCE_H_
7 7
8 #include <queue> 8 #include <queue>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 }; 254 };
255 255
256 PrintSettings print_settings_; 256 PrintSettings print_settings_;
257 257
258 scoped_ptr<PDFEngine> engine_; 258 scoped_ptr<PDFEngine> engine_;
259 259
260 // This engine is used to render the individual preview page data. This is 260 // This engine is used to render the individual preview page data. This is
261 // used only in print preview mode. This will use |PreviewModeClient| 261 // used only in print preview mode. This will use |PreviewModeClient|
262 // interface which has very limited access to the pp::Instance. 262 // interface which has very limited access to the pp::Instance.
263 scoped_ptr<PDFEngine> preview_engine_; 263 scoped_ptr<PDFEngine> preview_engine_;
264 scoped_ptr<PreviewModeClient> preview_client_;
Lei Zhang 2015/09/07 19:31:46 Doesn't member destruction go bottom up? i.e. as i
raymes 2015/09/07 23:59:00 Done.
264 265
265 std::string url_; 266 std::string url_;
266 267
267 // Used for submitting forms. 268 // Used for submitting forms.
268 pp::CompletionCallbackFactory<OutOfProcessInstance> form_factory_; 269 pp::CompletionCallbackFactory<OutOfProcessInstance> form_factory_;
269 pp::URLLoader form_loader_; 270 pp::URLLoader form_loader_;
270 271
271 // Used for printing without re-entrancy issues. 272 // Used for printing without re-entrancy issues.
272 pp::CompletionCallbackFactory<OutOfProcessInstance> print_callback_factory_; 273 pp::CompletionCallbackFactory<OutOfProcessInstance> print_callback_factory_;
273 274
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 // The blank space above the first page of the document reserved for the 337 // The blank space above the first page of the document reserved for the
337 // toolbar. 338 // toolbar.
338 int top_toolbar_height_; 339 int top_toolbar_height_;
339 340
340 DISALLOW_COPY_AND_ASSIGN(OutOfProcessInstance); 341 DISALLOW_COPY_AND_ASSIGN(OutOfProcessInstance);
341 }; 342 };
342 343
343 } // namespace chrome_pdf 344 } // namespace chrome_pdf
344 345
345 #endif // PDF_OUT_OF_PROCESS_INSTANCE_H_ 346 #endif // PDF_OUT_OF_PROCESS_INSTANCE_H_
OLDNEW
« no previous file with comments | « no previous file | pdf/out_of_process_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698