[Android] Remove runtime log level checks

[Android] Remove runtime log level checks

This means that all logs are now printed. Debug logs
are still removed from release builds, but they will
now show up on bots using debug builds.

BUG=527017
Committed: https://crrev.com/be11748b981dc42f5cd2aea606ea94b4b58b9202
Cr-Commit-Position: refs/heads/master@{#346682}

[dgn, 2015-09-01 15:30:35]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org, yfriedman@chromium.org

[dgn, 2015-09-01 15:30:35]

PTAL. This is to enable debug logs on bots. See the discussion on the bug.

[Bernhard Bauer, 2015-09-01 15:39:48]

lgtm

https://codereview.chromium.org/1323943004/diff/40001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/README_logging.md (right):

https://codereview.chromium.org/1323943004/diff/40001/base/android/java/src/o...
base/android/java/src/org/chromium/base/README_logging.md:77: Proguard removes
the method call itself, but doesn't do anything about the arguments. The
General nit: Lines longer than 80 columns don't look particularly good here 😕
Markdown should be able to handle line breaks, as it uses empty lines to
separate paragraphs, right?

Maybe we need a Markdown style guide ☺

[dgn, 2015-09-01 15:52:29]

On 2015/09/01 15:39:48, Bernhard Bauer wrote:
> lgtm
> 
>
https://codereview.chromium.org/1323943004/diff/40001/base/android/java/src/o...
> File base/android/java/src/org/chromium/base/README_logging.md (right):
> 
>
https://codereview.chromium.org/1323943004/diff/40001/base/android/java/src/o...
> base/android/java/src/org/chromium/base/README_logging.md:77: Proguard removes
> the method call itself, but doesn't do anything about the arguments. The
> General nit: Lines longer than 80 columns don't look particularly good here 😕
> Markdown should be able to handle line breaks, as it uses empty lines to
> separate paragraphs, right?
> 
> Maybe we need a Markdown style guide ☺

True, I just stayed coherent with the rest of the doc. BTW, should I move it to
//docs? we have a bunch of docs in there already. That can be a separate patch
too, move+reformat

[Bernhard Bauer, 2015-09-01 16:06:58]

On 2015/09/01 15:52:29, dgn wrote:
> On 2015/09/01 15:39:48, Bernhard Bauer wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/1323943004/diff/40001/base/android/java/src/o...
> > File base/android/java/src/org/chromium/base/README_logging.md (right):
> > 
> >
>
https://codereview.chromium.org/1323943004/diff/40001/base/android/java/src/o...
> > base/android/java/src/org/chromium/base/README_logging.md:77: Proguard
removes
> > the method call itself, but doesn't do anything about the arguments. The
> > General nit: Lines longer than 80 columns don't look particularly good here
😕
> > Markdown should be able to handle line breaks, as it uses empty lines to
> > separate paragraphs, right?
> > 
> > Maybe we need a Markdown style guide ☺
> 
> True, I just stayed coherent with the rest of the doc. BTW, should I move it
to
> //docs? we have a bunch of docs in there already. That can be a separate patch
> too, move+reformat

Yeah, good idea!

[Yaron, 2015-09-01 17:17:44]

I take it this isn't overly spammy? lgtm

[dgn, 2015-09-01 17:30:40]

On 2015/09/01 17:17:44, Yaron wrote:
> I take it this isn't overly spammy? lgtm

Quite spammy in Debug, but nothing crazy. And for release it doesn't change
anything. I'll send a follow up CL to move the readme.

[dgn, 2015-09-01 17:30:44]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2015-09-01 17:31:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323943004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323943004/60001

[commit-bot: I haz the power, 2015-09-01 17:37:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-01 17:38:01]

Patchset 4 (id:??) landed as
https://crrev.com/be11748b981dc42f5cd2aea606ea94b4b58b9202
Cr-Commit-Position: refs/heads/master@{#346682}