Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1323933003: Avoid to use static member function VisibleSelection::selectionType() in PendingSelection class (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid to use static member function VisibleSelection::selectionType() in PendingSelection class This patch replaces static member function |VisibleSelection::selectionType()| by |VisibleSelection::Strategy::selectionType()| in |PendingSelection| class as preparation of moving |VisibleSelection::selctionType()| out from |VisibleSelection| as local static function, since it is used only |PendingSelection| and |VisibleSelection| classes for ease of templatizing |VisibleSelection| to introduce composed tree version. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201625

Patch Set 1 : 2015-09-02T13:22:23 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/layout/PendingSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-02 04:40:23 UTC) #2
tkent
lgtm
5 years, 3 months ago (2015-09-02 04:52:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323933003/1
5 years, 3 months ago (2015-09-02 04:57:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/106983)
5 years, 3 months ago (2015-09-02 06:19:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323933003/1
5 years, 3 months ago (2015-09-02 06:38:26 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 07:32:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201625

Powered by Google App Engine
This is Rietveld 408576698