Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1323853005: Revert of Task Manager Should remember the most recently enabled columns. (Closed)

Created:
5 years, 3 months ago by horo
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang, afakhry
CC:
chromium-reviews, tfarina, ncarter (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Task Manager Should remember the most recently enabled columns. (patchset #6 id:100001 of https://codereview.chromium.org/1320563002/ ) Reason for revert: NewTaskManagerViewTest.ColumnsSettingsAreRestored crashes on Linux ChromiumOS Tests (dbg)(1). https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/6380/steps/browser_tests/logs/NewTaskManagerViewTest.ColumnsSettingsAreRestored Original issue's description: > Task Manager Should remember the most recently enabled columns. > > This CL: > 1- Makes adding and removing columns to the task manager a lot easier > and cleaner. > 2- Stores/retrieves the columns visibility to/from the local state > prefs. > 3- Stores/retrieves the sorted column and the sort order. > > R=thestig@chromium.org > BUG=452521 > TEST=browser_tests --gtest_filter=NewTaskManagerViewTest.* > > Committed: https://crrev.com/4e16add803fbb0ed18413496d3fb4424fa4957c6 > Cr-Commit-Position: refs/heads/master@{#346524} TBR=thestig@chromium.org,afakhry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452521 Committed: https://crrev.com/632a48fe73baa3f24e8273ecd8fa549764edc57a Cr-Commit-Position: refs/heads/master@{#346556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -425 lines) Patch
M chrome/browser/task_manager/task_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/new_task_manager_view.h View 3 chunks +0 lines, -57 lines 0 comments Download
M chrome/browser/ui/views/new_task_manager_view.cc View 8 chunks +140 lines, -228 lines 0 comments Download
D chrome/browser/ui/views/new_task_manager_view_browsertest.cc View 1 chunk +0 lines, -133 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
horo
Created Revert of Task Manager Should remember the most recently enabled columns.
5 years, 3 months ago (2015-09-01 02:09:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323853005/1
5 years, 3 months ago (2015-09-01 02:10:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 02:10:51 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 02:11:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/632a48fe73baa3f24e8273ecd8fa549764edc57a
Cr-Commit-Position: refs/heads/master@{#346556}

Powered by Google App Engine
This is Rietveld 408576698