Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 132383005: Set correct viewport size for an out of process iframe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 5aa6180952a54384fa6af44614556780535ac550..ba23b03c083eb61e349e6de9b03d56af62f440e8 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -438,6 +438,8 @@ void RenderFrameImpl::OnSwapOut() {
// frame?
frame_->stopLoading();
+ frame_->setIsRemote(true);
Charlie Reis 2014/02/04 20:11:12 Do we need to set this back to false when swapping
kenrb 2014/02/04 21:45:03 The latter. We don't swap subframes back in yet.
+
// Replace the page with a blank dummy URL. The unload handler will not be
// run a second time, thanks to a check in FrameLoader::stopLoading.
// TODO(creis): Need to add a better way to do this that avoids running the
@@ -1629,6 +1631,12 @@ void RenderFrameImpl::showContextMenu(const blink::WebContextMenuData& data) {
Send(new FrameHostMsg_ContextMenu(routing_id_, params));
}
+void RenderFrameImpl::initializeChildFrame(const blink::WebRect& frame_rect,
Charlie Reis 2014/02/04 20:11:12 Just to be sure I follow, you're expecting this to
kenrb 2014/02/04 21:45:03 Yes it is implementing a virtual method from the W
+ float scale_factor) {
+ Send(new FrameHostMsg_InitializeChildFrame(
+ routing_id_, frame_rect, scale_factor));
+}
+
void RenderFrameImpl::AddObserver(RenderFrameObserver* observer) {
observers_.AddObserver(observer);
}

Powered by Google App Engine
This is Rietveld 408576698