Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: src/gpu/GrGpu.h

Issue 1323823003: Remove GrGpuTraceMarker hooks until we rethink the design (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: compiler warning Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrDrawTarget.cpp ('k') | src/gpu/GrGpu.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrGpu.h
diff --git a/src/gpu/GrGpu.h b/src/gpu/GrGpu.h
index 290e981dc31791ee3e42ee44f6a97e27894e9038..08837ccde88f1465b79fd1f89a8f1670c11d8bc9 100644
--- a/src/gpu/GrGpu.h
+++ b/src/gpu/GrGpu.h
@@ -11,7 +11,6 @@
#include "GrPipelineBuilder.h"
#include "GrProgramDesc.h"
#include "GrStencil.h"
-#include "GrTraceMarker.h"
#include "GrXferProcessor.h"
#include "SkPath.h"
@@ -363,25 +362,6 @@ public:
Stats* stats() { return &fStats; }
- /**
- * Called at start and end of gpu trace marking
- * GR_CREATE_GPU_TRACE_MARKER(marker_str, target) will automatically call these at the start
- * and end of a code block respectively
- */
- void addGpuTraceMarker(const GrGpuTraceMarker* marker);
- void removeGpuTraceMarker(const GrGpuTraceMarker* marker);
-
- /**
- * Takes the current active set of markers and stores them for later use. Any current marker
- * in the active set is removed from the active set and the targets remove function is called.
- * These functions do not work as a stack so you cannot call save a second time before calling
- * restore. Also, it is assumed that when restore is called the current active set of markers
- * is empty. When the stored markers are added back into the active set, the targets add marker
- * is called.
- */
- void saveActiveTraceMarkers();
- void restoreActiveTraceMarkers();
-
// creation and deletion of raw texture for testing
// only to be used in GPU-specific tests
virtual GrBackendObject createTestingOnlyBackendTexture(void* pixels, int w, int h,
@@ -417,8 +397,6 @@ protected:
*preference = SkTMax(*preference, elevation);
}
- const GrTraceMarkerSet& getActiveTraceMarkers() const { return fActiveTraceMarkers; }
-
Stats fStats;
SkAutoTDelete<GrPathRendering> fPathRendering;
// Subclass must initialize this in its constructor.
@@ -499,9 +477,6 @@ private:
// clears target's entire stencil buffer to 0
virtual void clearStencil(GrRenderTarget* target) = 0;
- virtual void didAddGpuTraceMarker() = 0;
- virtual void didRemoveGpuTraceMarker() = 0;
-
void resetContext() {
this->onResetContext(fResetBits);
fResetBits = 0;
@@ -516,10 +491,6 @@ private:
ResetTimestamp fResetTimestamp;
uint32_t fResetBits;
- // To keep track that we always have at least as many debug marker adds as removes
- int fGpuTraceMarkerCount;
- GrTraceMarkerSet fActiveTraceMarkers;
- GrTraceMarkerSet fStoredTraceMarkers;
// The context owns us, not vice-versa, so this ptr is not ref'ed by Gpu.
GrContext* fContext;
« no previous file with comments | « src/gpu/GrDrawTarget.cpp ('k') | src/gpu/GrGpu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698