Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1323823003: Remove GrGpuTraceMarker hooks until we rethink the design (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrGpuTraceMarker hooks until we rethink the design TBR=bsalomon@google.com BUG=526308 Committed: https://skia.googlesource.com/skia/+/dac7005b877c7c1c6f36b6e298133dfc7b85b9c0

Patch Set 1 #

Patch Set 2 : compiler warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -197 lines) Patch
M include/gpu/GrContext.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 4 chunks +0 lines, -27 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +0 lines, -44 lines 0 comments Download
M src/gpu/GrGpu.h View 5 chunks +0 lines, -29 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +0 lines, -42 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrTracing.h View 1 1 chunk +8 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
joshualitt
ptal
5 years, 3 months ago (2015-09-01 14:49:56 UTC) #2
egdaniel
lgtm
5 years, 3 months ago (2015-09-01 14:55:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323823003/1
5 years, 3 months ago (2015-09-01 15:00:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/5383)
5 years, 3 months ago (2015-09-01 15:01:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323823003/20001
5 years, 3 months ago (2015-09-01 15:05:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2312)
5 years, 3 months ago (2015-09-01 15:06:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323823003/20001
5 years, 3 months ago (2015-09-01 15:19:20 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 15:19:50 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/dac7005b877c7c1c6f36b6e298133dfc7b85b9c0

Powered by Google App Engine
This is Rietveld 408576698