Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 13238002: [PPAPI] Documentation fixes. (Closed)

Created:
7 years, 9 months ago by binji
Modified:
7 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, raymes+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

[PPAPI] Documentation fixes. * I added a closing </code> tag in r191189, but it seems to be more consistent to forgo <code> tags for enums, so I've removed it. * I've also added @code/@endcode around a snippet of code that was flattened otherwise. BUG=none R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193162

Patch Set 1 #

Total comments: 2

Patch Set 2 : more @code/@endcode #

Patch Set 3 : merge master #

Patch Set 4 : merge again #

Patch Set 5 : merge yet again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -65 lines) Patch
M ppapi/api/pp_completion_callback.idl View 1 2 chunks +8 lines, -8 lines 0 comments Download
M ppapi/api/ppb_graphics_3d.idl View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M ppapi/api/ppb_input_event.idl View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/api/ppb_message_loop.idl View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/api/private/ppb_content_decryptor_private.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/pp_completion_callback.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M ppapi/c/ppb_graphics_3d.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M ppapi/c/ppb_input_event.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/c/ppb_message_loop.h View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M ppapi/c/private/ppb_content_decryptor_private.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/graphics_3d.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/input_event.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/instance.h View 1 2 6 chunks +10 lines, -10 lines 0 comments Download
M ppapi/cpp/logging.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/mouse_lock.h View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
binji
Sorry all the reviews, trying to help clean up the generated docs. :)
7 years, 9 months ago (2013-03-28 21:40:07 UTC) #1
dmichael (off chromium)
https://codereview.chromium.org/13238002/diff/1/ppapi/api/ppb_message_loop.idl File ppapi/api/ppb_message_loop.idl (right): https://codereview.chromium.org/13238002/diff/1/ppapi/api/ppb_message_loop.idl#newcode40 ppapi/api/ppb_message_loop.idl:40: * @code Is there any reason to not just ...
7 years, 9 months ago (2013-03-28 21:56:50 UTC) #2
binji
https://codereview.chromium.org/13238002/diff/1/ppapi/api/ppb_message_loop.idl File ppapi/api/ppb_message_loop.idl (right): https://codereview.chromium.org/13238002/diff/1/ppapi/api/ppb_message_loop.idl#newcode40 ppapi/api/ppb_message_loop.idl:40: * @code On 2013/03/28 21:56:50, dmichael wrote: > Is ...
7 years, 9 months ago (2013-03-28 22:02:24 UTC) #3
dmichael (off chromium)
On 2013/03/28 22:02:24, binji wrote: > https://codereview.chromium.org/13238002/diff/1/ppapi/api/ppb_message_loop.idl > File ppapi/api/ppb_message_loop.idl (right): > > https://codereview.chromium.org/13238002/diff/1/ppapi/api/ppb_message_loop.idl#newcode40 > ...
7 years, 9 months ago (2013-03-28 22:14:22 UTC) #4
binji
As long as I'm here, I'll fix the other spots too. It looks a lot ...
7 years, 9 months ago (2013-03-28 22:38:15 UTC) #5
dmichael (off chromium)
lgtm, only moreso. Thanks.
7 years, 9 months ago (2013-03-28 22:41:06 UTC) #6
binji
7 years, 8 months ago (2013-04-09 18:40:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r193162.

Powered by Google App Engine
This is Rietveld 408576698