src/compiler/mips64/code-generator-mips64.cc - Issue 1323763002: MIPS: Fixing illegal use of at register

Unified Diff: src/compiler/mips64/code-generator-mips64.cc

Issue 1323763002: MIPS: Fixing illegal use of at register (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/mips64/code-generator-mips64.cc

diff --git a/src/compiler/mips64/code-generator-mips64.cc b/src/compiler/mips64/code-generator-mips64.cc

index 670bd67435cb176bfdaf9c4c45235c918002c295..aeb8d135cd216cb8be77c2d74d3149761f500b78 100644

--- a/src/compiler/mips64/code-generator-mips64.cc

+++ b/src/compiler/mips64/code-generator-mips64.cc

@@ -305,8 +305,8 @@ FPUCondition FlagsConditionToConditionCmpFPU(bool& predicate,

if (instr->InputAt(0)->IsRegister()) { \

auto offset = i.InputRegister(0); \

__ Branch(USE_DELAY_SLOT, ool->entry(), hs, offset, i.InputOperand(1)); \

- __ Daddu(at, i.InputRegister(2), offset); \

- __ asm_instr(result, MemOperand(at, 0)); \

+ __ Daddu(t8, i.InputRegister(2), offset); \

+ __ asm_instr(result, MemOperand(t8, 0)); \

paul.l... 2015/08/31 22:56:34 I think these temp regs should be kScratchReg or p

Djordje.Pesic 2015/09/07 11:34:17 Done.

} else { \

int offset = static_cast<int>(i.InputOperand(0).immediate()); \

__ Branch(ool->entry(), ls, i.InputRegister(1), Operand(offset)); \

@@ -323,8 +323,8 @@ FPUCondition FlagsConditionToConditionCmpFPU(bool& predicate,

if (instr->InputAt(0)->IsRegister()) { \

auto offset = i.InputRegister(0); \

__ Branch(USE_DELAY_SLOT, ool->entry(), hs, offset, i.InputOperand(1)); \

- __ Daddu(at, i.InputRegister(2), offset); \

- __ asm_instr(result, MemOperand(at, 0)); \

+ __ Daddu(t8, i.InputRegister(2), offset); \

+ __ asm_instr(result, MemOperand(t8, 0)); \

} else { \

int offset = static_cast<int>(i.InputOperand(0).immediate()); \

__ Branch(ool->entry(), ls, i.InputRegister(1), Operand(offset)); \

@@ -341,8 +341,8 @@ FPUCondition FlagsConditionToConditionCmpFPU(bool& predicate,

auto offset = i.InputRegister(0); \

auto value = i.Input##width##Register(2); \

__ Branch(USE_DELAY_SLOT, &done, hs, offset, i.InputOperand(1)); \

- __ Daddu(at, i.InputRegister(3), offset); \

- __ asm_instr(value, MemOperand(at, 0)); \

+ __ Daddu(t8, i.InputRegister(3), offset); \

+ __ asm_instr(value, MemOperand(t8, 0)); \

} else { \

int offset = static_cast<int>(i.InputOperand(0).immediate()); \

auto value = i.Input##width##Register(2); \

@@ -360,8 +360,8 @@ FPUCondition FlagsConditionToConditionCmpFPU(bool& predicate,

auto offset = i.InputRegister(0); \

auto value = i.InputRegister(2); \

__ Branch(USE_DELAY_SLOT, &done, hs, offset, i.InputOperand(1)); \

- __ Daddu(at, i.InputRegister(3), offset); \

- __ asm_instr(value, MemOperand(at, 0)); \

+ __ Daddu(t8, i.InputRegister(3), offset); \

+ __ asm_instr(value, MemOperand(t8, 0)); \

} else { \

int offset = static_cast<int>(i.InputOperand(0).immediate()); \

auto value = i.InputRegister(2); \

« src/compiler/mips/code-generator-mips.cc ('K') | « src/compiler/mips/code-generator-mips.cc ('k') | src/mips/assembler-mips.cc » ('j') | src/mips/assembler-mips.cc » ('J')