Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: src/mips64/assembler-mips64.cc

Issue 1323763002: MIPS: Fixing illegal use of at register (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 2360 matching lines...) Expand 10 before | Expand all | Expand 10 after
2371 if (is_int16(src.offset_)) { 2371 if (is_int16(src.offset_)) {
2372 GenInstrImmediate(LWC1, src.rm(), fd, src.offset_); 2372 GenInstrImmediate(LWC1, src.rm(), fd, src.offset_);
2373 } else { // Offset > 16 bits, use multiple instructions to load. 2373 } else { // Offset > 16 bits, use multiple instructions to load.
2374 LoadRegPlusOffsetToAt(src); 2374 LoadRegPlusOffsetToAt(src);
2375 GenInstrImmediate(LWC1, at, fd, 0); 2375 GenInstrImmediate(LWC1, at, fd, 0);
2376 } 2376 }
2377 } 2377 }
2378 2378
2379 2379
2380 void Assembler::ldc1(FPURegister fd, const MemOperand& src) { 2380 void Assembler::ldc1(FPURegister fd, const MemOperand& src) {
2381 DCHECK(!src.rm().is(at));
2381 if (is_int16(src.offset_)) { 2382 if (is_int16(src.offset_)) {
2382 GenInstrImmediate(LDC1, src.rm(), fd, src.offset_); 2383 GenInstrImmediate(LDC1, src.rm(), fd, src.offset_);
2383 } else { // Offset > 16 bits, use multiple instructions to load. 2384 } else { // Offset > 16 bits, use multiple instructions to load.
2384 LoadRegPlusOffsetToAt(src); 2385 LoadRegPlusOffsetToAt(src);
2385 GenInstrImmediate(LDC1, at, fd, 0); 2386 GenInstrImmediate(LDC1, at, fd, 0);
2386 } 2387 }
2387 } 2388 }
2388 2389
2389 2390
2390 void Assembler::swc1(FPURegister fd, const MemOperand& src) { 2391 void Assembler::swc1(FPURegister fd, const MemOperand& src) {
2391 if (is_int16(src.offset_)) { 2392 if (is_int16(src.offset_)) {
2392 GenInstrImmediate(SWC1, src.rm(), fd, src.offset_); 2393 GenInstrImmediate(SWC1, src.rm(), fd, src.offset_);
2393 } else { // Offset > 16 bits, use multiple instructions to load. 2394 } else { // Offset > 16 bits, use multiple instructions to load.
2394 LoadRegPlusOffsetToAt(src); 2395 LoadRegPlusOffsetToAt(src);
2395 GenInstrImmediate(SWC1, at, fd, 0); 2396 GenInstrImmediate(SWC1, at, fd, 0);
2396 } 2397 }
2397 } 2398 }
2398 2399
2399 2400
2400 void Assembler::sdc1(FPURegister fd, const MemOperand& src) { 2401 void Assembler::sdc1(FPURegister fd, const MemOperand& src) {
2402 DCHECK(!src.rm().is(at));
2401 if (is_int16(src.offset_)) { 2403 if (is_int16(src.offset_)) {
2402 GenInstrImmediate(SDC1, src.rm(), fd, src.offset_); 2404 GenInstrImmediate(SDC1, src.rm(), fd, src.offset_);
2403 } else { // Offset > 16 bits, use multiple instructions to load. 2405 } else { // Offset > 16 bits, use multiple instructions to load.
2404 LoadRegPlusOffsetToAt(src); 2406 LoadRegPlusOffsetToAt(src);
2405 GenInstrImmediate(SDC1, at, fd, 0); 2407 GenInstrImmediate(SDC1, at, fd, 0);
2406 } 2408 }
2407 } 2409 }
2408 2410
2409 2411
2410 void Assembler::mtc1(Register rt, FPURegister fs) { 2412 void Assembler::mtc1(Register rt, FPURegister fs) {
(...skipping 863 matching lines...) Expand 10 before | Expand all | Expand 10 after
3274 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 3276 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
3275 CpuFeatures::FlushICache(pc, 4 * Assembler::kInstrSize); 3277 CpuFeatures::FlushICache(pc, 4 * Assembler::kInstrSize);
3276 } 3278 }
3277 } 3279 }
3278 3280
3279 3281
3280 } // namespace internal 3282 } // namespace internal
3281 } // namespace v8 3283 } // namespace v8
3282 3284
3283 #endif // V8_TARGET_ARCH_MIPS64 3285 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698