Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/mips64/assembler-mips64.cc

Issue 1323763002: MIPS: Fixing illegal use of at register (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/mips/assembler-mips.cc ('K') | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 2358 matching lines...) Expand 10 before | Expand all | Expand 10 after
2369 if (is_int16(src.offset_)) { 2369 if (is_int16(src.offset_)) {
2370 GenInstrImmediate(LWC1, src.rm(), fd, src.offset_); 2370 GenInstrImmediate(LWC1, src.rm(), fd, src.offset_);
2371 } else { // Offset > 16 bits, use multiple instructions to load. 2371 } else { // Offset > 16 bits, use multiple instructions to load.
2372 LoadRegPlusOffsetToAt(src); 2372 LoadRegPlusOffsetToAt(src);
2373 GenInstrImmediate(LWC1, at, fd, 0); 2373 GenInstrImmediate(LWC1, at, fd, 0);
2374 } 2374 }
2375 } 2375 }
2376 2376
2377 2377
2378 void Assembler::ldc1(FPURegister fd, const MemOperand& src) { 2378 void Assembler::ldc1(FPURegister fd, const MemOperand& src) {
2379 CHECK(!src.rm().is(at));
paul.l... 2015/08/31 22:56:34 DCHECK() here and below.
Djordje.Pesic 2015/09/07 11:34:17 Done.
2379 if (is_int16(src.offset_)) { 2380 if (is_int16(src.offset_)) {
2380 GenInstrImmediate(LDC1, src.rm(), fd, src.offset_); 2381 GenInstrImmediate(LDC1, src.rm(), fd, src.offset_);
2381 } else { // Offset > 16 bits, use multiple instructions to load. 2382 } else { // Offset > 16 bits, use multiple instructions to load.
2382 LoadRegPlusOffsetToAt(src); 2383 LoadRegPlusOffsetToAt(src);
2383 GenInstrImmediate(LDC1, at, fd, 0); 2384 GenInstrImmediate(LDC1, at, fd, 0);
2384 } 2385 }
2385 } 2386 }
2386 2387
2387 2388
2388 void Assembler::swc1(FPURegister fd, const MemOperand& src) { 2389 void Assembler::swc1(FPURegister fd, const MemOperand& src) {
2389 if (is_int16(src.offset_)) { 2390 if (is_int16(src.offset_)) {
2390 GenInstrImmediate(SWC1, src.rm(), fd, src.offset_); 2391 GenInstrImmediate(SWC1, src.rm(), fd, src.offset_);
2391 } else { // Offset > 16 bits, use multiple instructions to load. 2392 } else { // Offset > 16 bits, use multiple instructions to load.
2392 LoadRegPlusOffsetToAt(src); 2393 LoadRegPlusOffsetToAt(src);
2393 GenInstrImmediate(SWC1, at, fd, 0); 2394 GenInstrImmediate(SWC1, at, fd, 0);
2394 } 2395 }
2395 } 2396 }
2396 2397
2397 2398
2398 void Assembler::sdc1(FPURegister fd, const MemOperand& src) { 2399 void Assembler::sdc1(FPURegister fd, const MemOperand& src) {
2400 CHECK(!src.rm().is(at));
2399 if (is_int16(src.offset_)) { 2401 if (is_int16(src.offset_)) {
2400 GenInstrImmediate(SDC1, src.rm(), fd, src.offset_); 2402 GenInstrImmediate(SDC1, src.rm(), fd, src.offset_);
2401 } else { // Offset > 16 bits, use multiple instructions to load. 2403 } else { // Offset > 16 bits, use multiple instructions to load.
2402 LoadRegPlusOffsetToAt(src); 2404 LoadRegPlusOffsetToAt(src);
2403 GenInstrImmediate(SDC1, at, fd, 0); 2405 GenInstrImmediate(SDC1, at, fd, 0);
2404 } 2406 }
2405 } 2407 }
2406 2408
2407 2409
2408 void Assembler::mtc1(Register rt, FPURegister fs) { 2410 void Assembler::mtc1(Register rt, FPURegister fs) {
(...skipping 863 matching lines...) Expand 10 before | Expand all | Expand 10 after
3272 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 3274 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
3273 CpuFeatures::FlushICache(pc, 4 * Assembler::kInstrSize); 3275 CpuFeatures::FlushICache(pc, 4 * Assembler::kInstrSize);
3274 } 3276 }
3275 } 3277 }
3276 3278
3277 3279
3278 } // namespace internal 3280 } // namespace internal
3279 } // namespace v8 3281 } // namespace v8
3280 3282
3281 #endif // V8_TARGET_ARCH_MIPS64 3283 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« src/mips/assembler-mips.cc ('K') | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698