Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 132373013: Allow WebAudio decodeAudioData() to be more resilient to bad streams. (Closed)

Created:
6 years, 10 months ago by DaleCurtis
Modified:
6 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Allow WebAudio decodeAudioData() to be more resilient to bad streams. In the standard HTML5 audio path we simply skip over these errors after throwing out the current packet. We should do the same thing in WebAudio. BUG=170147 TEST=test case on bug works correctly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M media/filters/audio_file_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/audio_file_reader_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
DaleCurtis
Riley, you've spent a lot of time digging on FFmpegAudioDecoder lately, how about a review?
6 years, 10 months ago (2014-02-12 02:08:27 UTC) #1
rileya (GONE FROM CHROMIUM)
On 2014/02/12 02:08:27, DaleCurtis wrote: > Riley, you've spent a lot of time digging on ...
6 years, 10 months ago (2014-02-12 02:27:24 UTC) #2
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 10 months ago (2014-02-12 02:31:37 UTC) #3
DaleCurtis
Thanks!
6 years, 10 months ago (2014-02-12 02:31:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 02:32:49 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-12 02:32:50 UTC) #6
DaleCurtis
+acolwell Riley lacks the POWER unfortunately. Apparently OWNER created CLs can be approved by non-owners, ...
6 years, 10 months ago (2014-02-12 18:51:06 UTC) #7
DaleCurtis
->xhwang instead, acolwell is out today.
6 years, 10 months ago (2014-02-12 19:09:21 UTC) #8
xhwang
lgtm
6 years, 10 months ago (2014-02-12 19:13:37 UTC) #9
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 10 months ago (2014-02-12 19:21:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/132373013/1
6 years, 10 months ago (2014-02-12 19:22:09 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 23:37:23 UTC) #12
Message was sent while issue was closed.
Change committed as 250842

Powered by Google App Engine
This is Rietveld 408576698