Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: PRESUBMIT.py

Issue 132373003: Revert of Testing Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | whitespace.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index cf46862354d71cb7d00c5bb0098b568237f6be33..e89073528a2b28c70b028caae751bb908cbf8646 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -63,6 +63,7 @@ def CheckChangeOnUpload(input_api, output_api):
"""
results = []
results.extend(_CommonChecks(input_api, output_api))
+ results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
return results
@@ -127,6 +128,11 @@ def _CheckLGTMsForPublicAPI(input_api, output_api):
if issue and input_api.rietveld:
issue_properties = input_api.rietveld.get_issue_properties(
issue=int(issue), messages=True)
+ # TODO(rmistry): Check the description here and determine if it is a
+ # one-click revert CL. Just look at the subject actually and then determine this!
+ print 'HERE HERE'
+ print issue_properties['subject']
+ print 'HERE HERE'
if issue_properties['owner_email'] in PUBLIC_API_OWNERS:
# An owner created the CL that is an automatic LGTM.
lgtm_from_owner = True
@@ -139,6 +145,8 @@ def _CheckLGTMsForPublicAPI(input_api, output_api):
# Found an lgtm in a message from an owner.
lgtm_from_owner = True
break;
+ else:
+ print 'NO ISSUE AVAILABLE!!!!!!!!!!!!!!!!!!!!!'
if not lgtm_from_owner:
results.append(
« no previous file with comments | « no previous file | whitespace.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698