Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 1323663003: MIPS64: Fix alignment issue in test-run-native-calls. (Closed)

Created:
5 years, 3 months ago by paul.l...
Modified:
5 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix alignment issue in test-run-native-calls. BUG= Committed: https://crrev.com/445747ad203d2b5bd0626af81dc17ba89723290b Cr-Commit-Position: refs/heads/master@{#30479}

Patch Set 1 : 'output' type double (ugly) #

Patch Set 2 : Use gcc/clang alignment attribute, probably NOT msvc compatible. #

Patch Set 3 : Use v8 alignment attribute, which should work on msvc. #

Patch Set 4 : Fix V8_ALIGNED usage for MSVC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M test/cctest/compiler/test-run-native-calls.cc View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
paul.l...
Neither of these solutions look pleasing/production-ready to me. Maybe you can suggest something more elegant. ...
5 years, 3 months ago (2015-08-29 02:38:40 UTC) #2
titzer
Aha, looks like it was just the output buffer which was unaligned. lgtm
5 years, 3 months ago (2015-08-29 07:20:47 UTC) #3
paul.l...
Windows builds are not happy, will investigate further on Monday.
5 years, 3 months ago (2015-08-31 03:43:05 UTC) #4
paul.l...
On 2015/08/31 03:43:05, paul.l... wrote: > Windows builds are not happy, will investigate further on ...
5 years, 3 months ago (2015-08-31 15:04:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323663003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323663003/60001
5 years, 3 months ago (2015-08-31 15:04:15 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-08-31 15:45:08 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 15:45:29 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/445747ad203d2b5bd0626af81dc17ba89723290b
Cr-Commit-Position: refs/heads/master@{#30479}

Powered by Google App Engine
This is Rietveld 408576698