Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: gpu/command_buffer/service/texture_manager.cc

Issue 1323593003: Log both GL and cpu-side memory in GLImage*Memory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gl/gl_image_memory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/texture_manager.cc
diff --git a/gpu/command_buffer/service/texture_manager.cc b/gpu/command_buffer/service/texture_manager.cc
index 84cc266494ce81dd5ac8bf0dcc19a4e3bc3dfd11..111acdc20790db3253622d93a9f3c58b7d88b32f 100644
--- a/gpu/command_buffer/service/texture_manager.cc
+++ b/gpu/command_buffer/service/texture_manager.cc
@@ -1264,6 +1264,10 @@ void Texture::SetLevelImage(
info.image = image;
UpdateCanRenderCondition();
UpdateHasImages();
+
+ // TODO(ericrk): Images may have complex sizing not accounted for by
+ // |estimated_size_|, we should add logic here to update |estimated_size_|
+ // based on the new GLImage. crbug.com/526298
}
gfx::GLImage* Texture::GetLevelImage(GLint target, GLint level) const {
« no previous file with comments | « no previous file | ui/gl/gl_image_memory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698