Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "ui/gl/gl_image_ref_counted_memory.h" | 5 #include "ui/gl/gl_image_ref_counted_memory.h" |
| 6 | 6 |
| 7 #include "base/logging.h" | 7 #include "base/logging.h" |
| 8 #include "base/memory/ref_counted_memory.h" | 8 #include "base/memory/ref_counted_memory.h" |
| 9 | 9 |
| 10 namespace gfx { | 10 namespace gfx { |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 34 ref_counted_memory_ = NULL; | 34 ref_counted_memory_ = NULL; |
| 35 } | 35 } |
| 36 | 36 |
| 37 void GLImageRefCountedMemory::OnMemoryDump( | 37 void GLImageRefCountedMemory::OnMemoryDump( |
| 38 base::trace_event::ProcessMemoryDump* pmd, | 38 base::trace_event::ProcessMemoryDump* pmd, |
| 39 uint64_t process_tracing_id, | 39 uint64_t process_tracing_id, |
| 40 const std::string& dump_name) { | 40 const std::string& dump_name) { |
| 41 // Log size 0 if |ref_counted_memory_| has been released. | 41 // Log size 0 if |ref_counted_memory_| has been released. |
| 42 size_t size_in_bytes = ref_counted_memory_ ? ref_counted_memory_->size() : 0; | 42 size_t size_in_bytes = ref_counted_memory_ ? ref_counted_memory_->size() : 0; |
| 43 | 43 |
| 44 // Dump under "/ref_counted_memory", as DumpGLTexture may also dump to | |
| 45 // "/gl_texture". | |
| 44 base::trace_event::MemoryAllocatorDump* dump = | 46 base::trace_event::MemoryAllocatorDump* dump = |
| 45 pmd->CreateAllocatorDump(dump_name); | 47 pmd->CreateAllocatorDump(dump_name + "/ref_counted_memory"); |
|
reveman
2015/08/28 18:18:44
nit: /private_memory ? although it doesn't matter
ericrk
2015/08/31 17:19:32
sgtm
| |
| 46 dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize, | 48 dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize, |
| 47 base::trace_event::MemoryAllocatorDump::kUnitsBytes, | 49 base::trace_event::MemoryAllocatorDump::kUnitsBytes, |
| 48 static_cast<uint64_t>(size_in_bytes)); | 50 static_cast<uint64_t>(size_in_bytes)); |
|
reveman
2015/08/28 18:18:43
We should also add an add ownership edge to the sy
ericrk
2015/08/31 17:19:32
done.
| |
| 51 | |
| 52 DumpGLTexture(pmd, dump_name); | |
| 49 } | 53 } |
| 50 | 54 |
| 51 } // namespace gfx | 55 } // namespace gfx |
| OLD | NEW |