Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1323573005: Fix flakiness of form-submission-cancelable.html. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, Habib Virji
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix flakiness of form-submission-cancelable.html. - Specify action= attributes to avoid recursive loading of form-submission-cancelable.html. - Sequentially submit two forms. - The FAIL line in the updated expectation file is intentional. BUG=353066, 196640 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -24 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/form-submission-cancelable.html View 3 chunks +13 lines, -22 lines 0 comments Download
M LayoutTests/fast/forms/form-submission-cancelable-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, please review this.
5 years, 3 months ago (2015-08-31 08:23:52 UTC) #2
keishi
LGTM
5 years, 3 months ago (2015-08-31 08:29:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323573005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323573005/1
5 years, 3 months ago (2015-08-31 08:34:55 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 08:41:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201475

Powered by Google App Engine
This is Rietveld 408576698