Add a GM for image filters applied to stroked primitives.

Add a GM for image filters applied to stroked primitives.

BUG=skia:3194
Committed: https://skia.googlesource.com/skia/+/2aec4e946610e14788d471e4a08d5b5593779ec1

[Stephen White, 2015-08-28 19:27:45]

senorblanco@chromium.org changed reviewers:
+ reed@google.com

[Stephen White, 2015-08-28 19:27:55]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-08-28 19:27:55]

Mike: PTAL. Thanks!

[Stephen White, 2015-08-28 19:34:15]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-28 19:34:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323573004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323573004/20001

[commit-bot: I haz the power, 2015-08-28 19:39:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 19:39:52]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-08-28 19:41:38]

lgtm w/ nits

https://codereview.chromium.org/1323573004/diff/20001/gm/imagefiltersstroked.cpp
File gm/imagefiltersstroked.cpp (right):

https://codereview.chromium.org/1323573004/diff/20001/gm/imagefiltersstroked....
gm/imagefiltersstroked.cpp:51: canvas->drawText("A", 1, r.centerX(),
r.centerY(), paint);
Cary will bark loudly if we draw fonts just to draw something (as it makes
comparing this GM with other platforms much harder). If you must draw text, see
if you can use his set_portable_typeface helper.

https://codereview.chromium.org/1323573004/diff/20001/gm/imagefiltersstroked....
gm/imagefiltersstroked.cpp:73: SkRect r = SkRect::MakeWH(SkIntToScalar(64),
SkIntToScalar(64));
nits: for literals, you don't need SkIntToScalar(), and it makes it harder to
read

[Stephen White, 2015-08-28 19:46:20]

https://codereview.chromium.org/1323573004/diff/20001/gm/imagefiltersstroked.cpp
File gm/imagefiltersstroked.cpp (right):

https://codereview.chromium.org/1323573004/diff/20001/gm/imagefiltersstroked....
gm/imagefiltersstroked.cpp:51: canvas->drawText("A", 1, r.centerX(),
r.centerY(), paint);
On 2015/08/28 19:41:38, reed1 wrote:
> Cary will bark loudly if we draw fonts just to draw something (as it makes
> comparing this GM with other platforms much harder). If you must draw text,
see
> if you can use his set_portable_typeface helper.

Removed.

https://codereview.chromium.org/1323573004/diff/20001/gm/imagefiltersstroked....
gm/imagefiltersstroked.cpp:73: SkRect r = SkRect::MakeWH(SkIntToScalar(64),
SkIntToScalar(64));
On 2015/08/28 19:41:38, reed1 wrote:
> nits: for literals, you don't need SkIntToScalar(), and it makes it harder to
> read

Removed.

[Stephen White, 2015-08-28 19:46:24]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2015-08-28 19:46:25]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1323573004/#ps20002
(title: "Fixes per review comments")

[commit-bot: I haz the power, 2015-08-28 19:46:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323573004/20002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323573004/20002

[Stephen White, 2015-08-28 19:51:02]

Patchset #4 (id:20003) has been deleted

[Stephen White, 2015-08-31 17:23:21]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2015-08-31 17:23:22]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1323573004/#ps20002
(title: "Fixes per review comments")

[commit-bot: I haz the power, 2015-08-31 17:23:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323573004/20002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323573004/20002

[commit-bot: I haz the power, 2015-08-31 17:28:52]

Committed patchset #3 (id:20002) as
https://skia.googlesource.com/skia/+/2aec4e946610e14788d471e4a08d5b5593779ec1