Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Issue 1323533003: Mimic Chrome better in our GYPs. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Mimic Chrome better in our GYPs. To match Chrome, make sure we've disabled thread-safe statics, RTTI, and exceptions. Linux needed -fno-threadsafe-statics, Mac needed all three. Nothing important triggered this CL. I just got confused when I saw exception handling (calls to delete, stack unwinding) in some generated code on my laptop. BUG=skia: Committed: https://skia.googlesource.com/skia/+/61a81e39477f881726b0a0565d50018c69155f00

Patch Set 1 #

Patch Set 2 : move to _cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mtklein_C
Sort of spraying for a reviewer: the lgtm of any one reviewer who understands all ...
5 years, 3 months ago (2015-09-09 17:25:01 UTC) #2
herb_g
lgtm
5 years, 3 months ago (2015-09-09 17:35:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323533003/1
5 years, 3 months ago (2015-09-09 17:36:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/1450)
5 years, 3 months ago (2015-09-09 17:37:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323533003/20001
5 years, 3 months ago (2015-09-09 17:40:54 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 17:46:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/61a81e39477f881726b0a0565d50018c69155f00

Powered by Google App Engine
This is Rietveld 408576698