Issue 132353006: Mojo: Rename public/tests/test_support.* -> test_utils.*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132353006: Mojo: Rename public/tests/test_support.* -> test_utils.*. (Closed)

Created:
6 years, 10 months ago by viettrungluu

Modified:
6 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Rename public/tests/test_support.* -> test_utils.*. I'm planning on reusing the name test_support for something slightly different: a dynamic library that can thunk to an implementation provided by the test runner (much like we do for system and gles2). This is so we can remove public/tests's base dependency (by injecting it instead). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251077

Patch Set 1 #

Patch Set 2 : grrr #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -149 lines)			Patch
M	mojo/common/handle_watcher_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/mojo.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/mojo_public.gypi	View	7 chunks	+8 lines, -8 lines	0 comments	Download
M	mojo/public/bindings/tests/handle_passing_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/environment/tests/async_waiter_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/tests/system/core_perftest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	mojo/public/tests/test_support.h	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	mojo/public/tests/test_support.cc	View	1 chunk	+0 lines, -91 lines	0 comments	Download
A +	mojo/public/tests/test_utils.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	mojo/public/tests/test_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/utility/tests/run_loop_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 10 months ago (2014-02-13 17:58:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r251077 (presubmit successful).

Expand Messages | Collapse Messages