Change chrome.downloads.DownloadItem.{fileSize,bytesReceived,totalBytes} from longs to doubles for …

Change chrome.downloads.DownloadItem.{fileSize,bytesReceived,totalBytes} from longs to doubles for files > 2GB.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244404

[asargent_no_longer_on_chrome, 2014-01-10 23:39:14]

I think this should be fine and shouldn't be too big a concern for backwards
compatibility even though technically I could imagine some code using the API
depending on these being integers and not doubles, but adding kalman just in
case to get a second opinion.

[not at google - send to devlin, 2014-01-10 23:46:42]

how do ints vs long vs doubles work in JS anyway? doesn't everything eventually
reduce to a double (modulo v8 doing magic to keep things integral if it can). so
this should be fine, lgtm.

https://codereview.chromium.org/132353002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/downloads.idl (right):

https://codereview.chromium.org/132353002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/downloads.idl:325: dictionary LongDelta {
no longer used

[asargent_no_longer_on_chrome, 2014-01-11 01:05:02]

On 2014/01/10 23:46:42, kalman wrote:
> how do ints vs long vs doubles work in JS anyway?

I was hoping you knew better than me. =)


> doesn't everything eventually
> reduce to a double (modulo v8 doing magic to keep things integral if it can).
so
> this should be fine, lgtm.

lgtm too

[benjhayden, 2014-01-12 00:04:06]

Thanks!

https://codereview.chromium.org/132353002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/downloads.idl (right):

https://codereview.chromium.org/132353002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/downloads.idl:325: dictionary LongDelta {
On 2014/01/10 23:46:43, kalman wrote:
> no longer used

Done.

[commit-bot: I haz the power, 2014-01-12 00:04:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/132353002/80001

[commit-bot: I haz the power, 2014-01-12 02:08:45]

Change committed as 244404