Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1323523002: Remove suppressInvalidations and suppressCompositorScheduling, they don't do anything. (Closed)

Created:
5 years, 3 months ago by esprehn
Modified:
5 years, 3 months ago
CC:
blink-reviews, dcheng, dglazkov+blink, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove suppressInvalidations and suppressCompositorScheduling, they don't do anything. suppressInvalidations just calls suppressCompositorScheduling, but that plumbing doesn't go anywhere. Lets remove it. R=ojan@chromium.org BUG=521692 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M Source/web/WebFrameWidgetImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebFrameWidgetImpl.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M public/web/WebWidgetClient.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
esprehn
5 years, 3 months ago (2015-08-28 09:11:42 UTC) #1
ojan
lgtm
5 years, 3 months ago (2015-08-28 09:17:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323523002/1
5 years, 3 months ago (2015-08-28 09:17:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/94076)
5 years, 3 months ago (2015-08-28 09:25:39 UTC) #7
esprehn
Need a public/web owner for a stamp.
5 years, 3 months ago (2015-08-28 12:57:56 UTC) #9
dglazkov
On 2015/08/28 at 12:57:56, esprehn wrote: > Need a public/web owner for a stamp. lol ...
5 years, 3 months ago (2015-08-28 14:40:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323523002/1
5 years, 3 months ago (2015-08-28 14:41:34 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 14:45:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201404

Powered by Google App Engine
This is Rietveld 408576698