Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 13235003: Support the Text services framework based IME for Chrome AURA on Windows. (Closed)

Created:
7 years, 8 months ago by ananta
Modified:
7 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, ctguil+watch_chromium.org, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, penghuang+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, tfarina, James Su, zork+watch_chromium.org
Visibility:
Public.

Description

Support the Text services framework based IME for Chrome AURA on Windows 8 and above and enable it by default for Chrome AURA. This change should not affect non AURA Chrome. The changes in this CL are mostly around setting the focused TextInputClient in the TSFBridgeDelegate class and not handling the traditional IME messages apart from WM_IME_SETCONTEXT in the input method win subclass. I also made a change in the TSFBridge class to ensure that Initialize can be called multiple times. ASH support will come in a subsequent change. Needs some more research there. Known issues:- 1. Clicking on the omnibox in Chrome AURA switches the current language setting back to ENG regardless of the last active language. We have to switch back to the desired lang each time on the omnibox. This works fine on the web page though. yukawa? do you have any ideas as to why? 2. Chinese IME's when used on the web page in Chrome AURA display the composition window at the top left corner of the desktop. This works correctly on the omnibox. yukawa? perhaps you may know. The views_test_base.h/.cc changes are needed for views unittests to pass The desktop_notifications_unittest.cc/.h and view_event_test_base.cc/.h changes are needed for interactive_ui_tests to pass. The ash_test_base.cc/.h changes are needed for ash_unittests to pass. BUG=225189 TBR=nona Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194205

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 1

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -9 lines) Patch
M ash/test/ash_test_base.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +5 lines, -0 lines 0 comments Download
M base/win/metro.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_win.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_win.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +36 lines, -1 line 0 comments Download
M ui/base/ime/win/mock_tsf_bridge.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/win/mock_tsf_bridge.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/ime/win/tsf_bridge.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ime/win/tsf_bridge.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +12 lines, -4 lines 0 comments Download
M ui/views/run_all_unittests.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ananta
7 years, 8 months ago (2013-03-30 01:00:25 UTC) #1
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/13235003/diff/79001/ui/base/ime/input_method_win.cc File ui/base/ime/input_method_win.cc (right): https://codereview.chromium.org/13235003/diff/79001/ui/base/ime/input_method_win.cc#newcode115 ui/base/ime/input_method_win.cc:115: return; this seems very important to do. If the ...
7 years, 8 months ago (2013-04-11 19:54:12 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
7 years, 8 months ago (2013-04-11 19:54:58 UTC) #3
Yohei Yukawa
On 2013/04/11 19:54:58, cpu wrote: > lgtm lgtm. Sorry for my delayed response.
7 years, 8 months ago (2013-04-12 04:12:18 UTC) #4
ananta
+sky. Please glance through the ui\ changes and hopefully grant OWNERS LGTM.
7 years, 8 months ago (2013-04-12 20:17:02 UTC) #5
sky
ui/aura and ui/views LGTM. I'm not a good reviewer for ui/base/ime though. Can you get ...
7 years, 8 months ago (2013-04-12 20:30:04 UTC) #6
ananta
TBR'ing nona for ui\base\ime. yukawa who also works on the IME code has already LGTM'ed ...
7 years, 8 months ago (2013-04-12 22:24:29 UTC) #7
Seigo Nonaka
lgtm
7 years, 8 months ago (2013-04-13 16:49:32 UTC) #8
ananta
7 years, 8 months ago (2013-04-15 19:06:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #11 manually as r194205 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698