Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 13235: Cleanup adding BoundsInWidget to View to convert callers... (Closed)

Created:
12 years ago by Mohamed Mansour (USE mhm)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Cleanup adding BoundsInWidget to View to convert callers from ConvertToWidget to use this instead BUG=5133 (http://crbug.com/5133)

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 8

Patch Set 4 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M chrome/browser/views/find_bar_win.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/views/hwnd_view.cc View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/views/tooltip_manager.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/views/view.h View 1 2 3 1 chunk +4 lines, -0 lines 1 comment Download
M chrome/views/view.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mohamed Mansour (USE mhm)
12 years ago (2008-12-06 17:21:20 UTC) #1
Peter Kasting
Are there places besides these that can use this function? It seems strange to add ...
12 years ago (2008-12-07 02:16:31 UTC) #2
Mohamed Mansour (USE mhm)
I hope that comment is good.. And yes, I was wondering the same thing why ...
12 years ago (2008-12-07 06:37:52 UTC) #3
Ben Goodger (Google)
http://codereview.chromium.org/13235/diff/409/31 File chrome/views/view.h (right): http://codereview.chromium.org/13235/diff/409/31#newcode660 Line 660: gfx::Rect BoundsInWidget(); Yeah I agree with Peter now ...
12 years ago (2008-12-08 20:40:08 UTC) #4
Mohamed Mansour (USE mhm)
So now I gotta roll back everything? Change back the naming from widget_bounds to top_left, ...
12 years ago (2008-12-08 23:47:50 UTC) #5
Mohamed Mansour (USE mhm)
But now, since we just need a Point, the method becomes this: gfx::Point View::PositionInWidget() { ...
12 years ago (2008-12-09 00:03:59 UTC) #6
Peter Kasting
On 2008/12/09 00:03:59, Mohamed Mansour wrote: > But now, since we just need a Point, ...
12 years ago (2008-12-09 00:06:45 UTC) #7
Peter Kasting
12 years ago (2008-12-09 00:50:32 UTC) #8
Closing per beng.

Powered by Google App Engine
This is Rietveld 408576698