Modifies V8WrapperInstantiationScope::SecurityCheck to only call BindingSecurity::shouldAllowAccess…

Source/bindings/core/v8/V8DOMWrapper.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 112 matching lines @@
     if (object->InternalFieldCount() < v8DefaultWrapperInternalFieldCount)
         return false;
 
     const ScriptWrappable* untrustedScriptWrappable = toScriptWrappable(object);
     const WrapperTypeInfo* untrustedWrapperTypeInfo = toWrapperTypeInfo(object);
     return untrustedScriptWrappable
         && untrustedWrapperTypeInfo
         && untrustedWrapperTypeInfo->ginEmbedder == gin::kEmbedderBlink;
 }
 
 void V8WrapperInstantiationScope::SecurityCheck(v8::Isolate* isolate, v8::Local<v8::Context> contextForWrapper)

[haraken, 2015/09/09 15:41:43]

SecurityCheck => securityCheck

[epertoso, 2015/09/09 15:52:11]

Done.

 {
     if (!m_context.IsEmpty()) {

[haraken, 2015/09/09 15:41:43]

You can early-return if m_context is empty.

[epertoso, 2015/09/09 15:52:11]

Done.

         // If the context is different, we need to make sure that the current
         // context has access to the creation context.
         Frame* frame = toFrameIfNotDetached(contextForWrapper);
-        RELEASE_ASSERT(!frame || BindingSecurity::shouldAllowAccessToFrame(isolate, frame, DoNotReportSecurityError));
+        if (!frame)
+            return;
+        const DOMWrapperWorld& currentWorld = DOMWrapperWorld::world(m_context);
+        RELEASE_ASSERT(currentWorld.worldId() == DOMWrapperWorld::world(contextForWrapper).worldId());

[haraken, 2015/09/09 15:41:42]

Does this need to be RELEASE_ASSERT?

[epertoso, 2015/09/09 15:52:11]

I think it's a valid assumption.

+        if (currentWorld.isMainWorld()) {
+            RELEASE_ASSERT(BindingSecurity::shouldAllowAccessToFrame(isolate, frame, DoNotReportSecurityError));
+        }
     }
 }
 
 } // namespace blink