content/renderer/media/renderer_webaudiodevice_impl.cc - Issue 1323403005: Allow AudioOutputDevice objects to be initialized with a specific hardware output device and store …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/renderer_webaudiodevice_impl.cc

Issue 1323403005: Allow AudioOutputDevice objects to be initialized with a specific hardware output device and store … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Palmer's comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/audio_renderer_host.cc ('K') | « content/renderer/media/audio_renderer_mixer_manager.cc ('k') | content/renderer/media/webmediaplayer_ms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/renderer_webaudiodevice_impl.cc

diff --git a/content/renderer/media/renderer_webaudiodevice_impl.cc b/content/renderer/media/renderer_webaudiodevice_impl.cc

index 5b697db3057213faf9faf31b197132660c4ae178..d816db3a418d1a6c35bd6805a3bb65313045262e 100644

--- a/content/renderer/media/renderer_webaudiodevice_impl.cc

+++ b/content/renderer/media/renderer_webaudiodevice_impl.cc

@@ -4,6 +4,8 @@

#include "content/renderer/media/renderer_webaudiodevice_impl.h"

+#include <string>

#include "base/command_line.h"

#include "base/logging.h"

#include "base/single_thread_task_runner.h"

@@ -65,8 +67,9 @@ void RendererWebAudioDeviceImpl::start() {

RenderFrame* const render_frame =

web_frame ? RenderFrame::FromWebFrame(web_frame) : NULL;

output_device_ = AudioDeviceFactory::NewOutputDevice(

- render_frame ? render_frame->GetRoutingID(): MSG_ROUTING_NONE);

- output_device_->InitializeWithSessionId(params_, this, session_id_);

+ render_frame ? render_frame->GetRoutingID() : MSG_ROUTING_NONE,

+ session_id_, std::string(), url::Origin());

+ output_device_->Initialize(params_, this);

output_device_->Start();

start_null_audio_sink_callback_.Reset(

base::Bind(&media::NullAudioSink::Play, null_audio_sink_));