Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2316)

Unified Diff: content/renderer/media/audio_device_factory.h

Issue 1323403005: Allow AudioOutputDevice objects to be initialized with a specific hardware output device and store … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Palmer's comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_device_factory.h
diff --git a/content/renderer/media/audio_device_factory.h b/content/renderer/media/audio_device_factory.h
index e50f13978be3231dae98e6cf1a233bc8ad75f0a8..e3f263102da11c351bc038903be0d061b3f68800 100644
--- a/content/renderer/media/audio_device_factory.h
+++ b/content/renderer/media/audio_device_factory.h
@@ -5,7 +5,10 @@
#ifndef CONTENT_RENDERER_MEDIA_AUDIO_DEVICE_FACTORY_H_
#define CONTENT_RENDERER_MEDIA_AUDIO_DEVICE_FACTORY_H_
+#include <string>
+
#include "base/basictypes.h"
+#include "base/callback.h"
#include "base/memory/ref_counted.h"
#include "content/common/content_export.h"
@@ -14,6 +17,10 @@ class AudioInputDevice;
class AudioOutputDevice;
}
+namespace url {
+class Origin;
+}
+
namespace content {
// A factory for creating AudioOutputDevices and AudioInputDevices. There is a
@@ -21,11 +28,19 @@ namespace content {
// provide specialized implementations.
class CONTENT_EXPORT AudioDeviceFactory {
public:
- // Creates an AudioOutputDevice using the currently registered factory.
+ // Creates an AudioOutputDevice.
// |render_frame_id| refers to the RenderFrame containing the entity
- // producing the audio.
+ // producing the audio. If |session_id| is nonzero, it is used by the browser
+ // to select the correct input device ID and its associated output device, if
+ // it exists. If |session_id| is zero, |device_id| and |security_origin|
+ // identify the output device to use.
+ // If |session_id| is zero and |device_id| and |security_origin| are empty,
+ // the default output device will be selected.
static scoped_refptr<media::AudioOutputDevice> NewOutputDevice(
- int render_frame_id);
+ int render_frame_id,
+ int session_id,
+ const std::string& device_id,
+ const url::Origin& security_origin);
// Creates an AudioInputDevice using the currently registered factory.
// |render_frame_id| refers to the RenderFrame containing the entity
@@ -41,7 +56,11 @@ class CONTENT_EXPORT AudioDeviceFactory {
// functions to provide alternate audio device implementations.
// If the return value of either of these function is NULL, we fall back
// on the default implementation.
- virtual media::AudioOutputDevice* CreateOutputDevice(int render_frame_id) = 0;
+ virtual media::AudioOutputDevice* CreateOutputDevice(
+ int render_frame_id,
+ int sesssion_id,
+ const std::string& device_id,
+ const url::Origin& security_origin) = 0;
virtual media::AudioInputDevice* CreateInputDevice(int render_frame_id) = 0;
private:

Powered by Google App Engine
This is Rietveld 408576698