Allow AudioOutputDevice objects to be initialized with a specific hardware output device and store …

content/renderer/pepper/pepper_platform_audio_output.cc

Index: content/renderer/pepper/pepper_platform_audio_output.cc
diff --git a/content/renderer/pepper/pepper_platform_audio_output.cc b/content/renderer/pepper/pepper_platform_audio_output.cc
index 010b30f75db5c87f8aa86e17c9c1f9262ad7b77d..b85b811a0d46e7fa6cf7f9f1e78617063cd2b87c 100644
--- a/content/renderer/pepper/pepper_platform_audio_output.cc
+++ b/content/renderer/pepper/pepper_platform_audio_output.cc
@@ -72,6 +72,10 @@ void PepperPlatformAudioOutput::ShutDown() {
 void PepperPlatformAudioOutput::OnStateChanged(
     media::AudioOutputIPCDelegateState state) {}
 
+void PepperPlatformAudioOutput::OnDeviceAuthorized(
+    bool success,
+    const media::AudioParameters& output_params) {}

[bbudge, 2015/09/15 11:39:42]

I'm assuming 'success' is always 'true' here. If so, DCHECK(success).

[Guido Urdaneta, 2015/09/15 11:55:14]

Actually, this is never called because the RequestDeviceAuthorization IPC is
never sent from here. It is not necessary because PPAO always uses the default
device.
Should we use NOTREACHED() instead?

[bbudge, 2015/09/15 12:59:12]

OK that's fine.

+
 void PepperPlatformAudioOutput::OnStreamCreated(
     base::SharedMemoryHandle handle,
     base::SyncSocket::Handle socket_handle,
@@ -98,7 +102,6 @@ void PepperPlatformAudioOutput::OnStreamCreated(
 }
 
 void PepperPlatformAudioOutput::OnOutputDeviceSwitched(
-    int request_id,
     media::SwitchOutputDeviceResult result) {}
 
 void PepperPlatformAudioOutput::OnIPCClosed() { ipc_.reset(); }
@@ -143,9 +146,8 @@ bool PepperPlatformAudioOutput::Initialize(int sample_rate,
 void PepperPlatformAudioOutput::InitializeOnIOThread(
     const media::AudioParameters& params) {
   DCHECK(io_task_runner_->BelongsToCurrentThread());
-  const int kSessionId = 0;
   if (ipc_)
-    ipc_->CreateStream(this, params, kSessionId);
+    ipc_->CreateStream(this, params);
 }
 
 void PepperPlatformAudioOutput::StartPlaybackOnIOThread() {