media/blink/webmediaplayer_impl.cc - Issue 1323403005: Allow AudioOutputDevice objects to be initialized with a specific hardware output device and store …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1323403005: Allow AudioOutputDevice objects to be initialized with a specific hardware output device and store … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Split permissions check and device-ID translation for clarity Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/webmediaplayer_impl.cc

diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc

index 1bc5cec70464474ba46592e9e3e3e70b50099d2d..ae6999e2543075d09bf57f76590a2ef30e10636f 100644

--- a/media/blink/webmediaplayer_impl.cc

+++ b/media/blink/webmediaplayer_impl.cc

@@ -408,7 +408,7 @@ void WebMediaPlayerImpl::setSinkId(const blink::WebString& device_id,

GURL security_origin(frame_->securityOrigin().toString().utf8());

output_device->SwitchOutputDevice(device_id_str, security_origin, callback);

} else {

- callback.Run(SWITCH_OUTPUT_DEVICE_RESULT_ERROR_NOT_SUPPORTED);

+ callback.Run(SWITCH_OUTPUT_DEVICE_RESULT_ERROR_INTERNAL);

}

« media/audio/audio_output_device.cc ('K') | « media/base/output_device.h ('k') | media/blink/webmediaplayer_util.cc » ('j') | no next file with comments »