Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2345)

Unified Diff: content/renderer/media/audio_device_factory.cc

Issue 1323403005: Allow AudioOutputDevice objects to be initialized with a specific hardware output device and store … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split permissions check and device-ID translation for clarity Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_device_factory.cc
diff --git a/content/renderer/media/audio_device_factory.cc b/content/renderer/media/audio_device_factory.cc
index 0cd9d4cac97eb4fb61bb8de0862626eb067b0ed5..054c0dd502587b12697ff2e02c1d0466c81e00b6 100644
--- a/content/renderer/media/audio_device_factory.cc
+++ b/content/renderer/media/audio_device_factory.cc
@@ -9,6 +9,7 @@
#include "content/renderer/media/audio_message_filter.h"
#include "media/audio/audio_input_device.h"
#include "media/audio/audio_output_device.h"
+#include "url/gurl.h"
namespace content {
@@ -26,8 +27,49 @@ scoped_refptr<media::AudioOutputDevice> AudioDeviceFactory::NewOutputDevice(
}
AudioMessageFilter* const filter = AudioMessageFilter::Get();
- return new media::AudioOutputDevice(
+ scoped_refptr<media::AudioOutputDevice> device = new media::AudioOutputDevice(
filter->CreateAudioOutputIPC(render_frame_id), filter->io_task_runner());
+ device->RequestDeviceAuthorization();
+ return device;
+}
+
+// static
+scoped_refptr<media::AudioOutputDevice> AudioDeviceFactory::NewOutputDevice(
+ int render_frame_id,
+ int session_id) {
+ if (factory_) {
DaleCurtis 2015/09/09 01:31:57 Ditto.
Guido Urdaneta 2015/09/09 16:22:23 This one is as deep as the one in l.56. This one t
+ media::AudioOutputDevice* const device =
+ factory_->CreateOutputDevice(render_frame_id, session_id);
+ if (device)
+ return device;
+ }
+
+ AudioMessageFilter* const filter = AudioMessageFilter::Get();
+ scoped_refptr<media::AudioOutputDevice> device = new media::AudioOutputDevice(
+ filter->CreateAudioOutputIPC(render_frame_id), filter->io_task_runner(),
+ session_id, std::string(), GURL::EmptyGURL());
+ device->RequestDeviceAuthorization();
+ return device;
+}
+
+// static
+scoped_refptr<media::AudioOutputDevice> AudioDeviceFactory::NewOutputDevice(
+ int render_frame_id,
+ const std::string& device_id,
+ const GURL& security_origin) {
+ if (factory_) {
+ media::AudioOutputDevice* const device = factory_->CreateOutputDevice(
+ render_frame_id, device_id, security_origin);
+ if (device)
+ return device;
+ }
+
+ AudioMessageFilter* const filter = AudioMessageFilter::Get();
+ scoped_refptr<media::AudioOutputDevice> device = new media::AudioOutputDevice(
+ filter->CreateAudioOutputIPC(render_frame_id), filter->io_task_runner(),
+ 0, device_id, security_origin);
+ device->RequestDeviceAuthorization();
+ return device;
}
// static

Powered by Google App Engine
This is Rietveld 408576698