Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 132333022: Keep original revision as a build property. (Closed)

Created:
6 years, 10 months ago by Paweł Hajdan Jr.
Modified:
6 years, 10 months ago
Reviewers:
iannucci
CC:
chromium-reviews, stip+watch_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

Keep original revision as a build property. This saves the revision we got from poller before possibly replacing it with LKGR. BUG=317931 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=247982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M scripts/master/try_job_base.py View 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/master/unittests/try_job_base_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
6 years, 10 months ago (2014-01-30 17:18:11 UTC) #1
iannucci
lgtm. see how much easier that is? :)
6 years, 10 months ago (2014-01-30 17:19:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/132333022/1
6 years, 10 months ago (2014-01-30 17:42:47 UTC) #3
commit-bot: I haz the power
Change committed as 247982
6 years, 10 months ago (2014-01-30 17:45:39 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 17:45:43 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698