Add FreeBSD as a supported platform using ninja.

build/landmine_utils.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 import functools
 import logging
 import os
 import shlex
 import sys
@@ skipping 15 matching lines @@
   return memoizer
 
 
 @memoize()
 def IsWindows():
   return sys.platform in ['win32', 'cygwin']
 
 
 @memoize()
 def IsLinux():
   return sys.platform.startswith('linux')

[iannucci, 2014/02/10 22:28:30]

For the purposes of this file, I think it would make more sense to just make
this:


....startswith(('linux', 'freebsd'))

[r.c.ladan, 2014/02/10 22:31:33]

What about platform() which cannot distinguish between Linux and FreeBSD in that
case? (They are different operating systems...)

[iannucci, 2014/02/10 22:38:39]

I know they're different operating systems :)

The purpose of this file is to indicate when a bot needs to clobber the checkout
due to a change in configuration. Since it's unlikely that we'll be introducing
FreeBSD landmines, and that FreeBSD machines will want to clobber at the same
times as the linux machines, it makes sense to merge the two together here.

If we ever start running FreeBSD continuous integration systems, then it would
make sense to split it out into a new method.

 
 
 @memoize()
 def IsMac():
   return sys.platform == 'darwin'
 
 
 @memoize()
+def IsFreeBSD():
+  return sys.platform.startswith('freebsd')
+
+
+@memoize()
 def gyp_defines():
   """Parses and returns GYP_DEFINES env var as a dictionary."""
   return dict(arg.split('=', 1)
       for arg in shlex.split(os.environ.get('GYP_DEFINES', '')))
 
 @memoize()
 def gyp_msvs_version():
   return os.environ.get('GYP_MSVS_VERSION', '')
 
 @memoize()
 def distributor():
   """
   Returns a string which is the distributed build engine in use (if any).
   Possible values: 'goma', 'ib', ''
   """
   if 'goma' in gyp_defines():
     return 'goma'
   elif IsWindows():
     if 'CHROME_HEADLESS' in os.environ:
       return 'ib' # use (win and !goma and headless) as approximation of ib
 
 
 @memoize()
 def platform():
   """
   Returns a string representing the platform this build is targetted for.
-  Possible values: 'win', 'mac', 'linux', 'ios', 'android'
+  Possible values: 'win', 'mac', 'linux', 'ios', 'android', 'freebsd'
   """
   if 'OS' in gyp_defines():
     if 'android' in gyp_defines()['OS']:
       return 'android'
     else:
       return gyp_defines()['OS']
   elif IsWindows():
     return 'win'
   elif IsLinux():
     return 'linux'
+  elif IsFreeBSD():
+    return 'freebsd'
   else:
     return 'mac'
 
 
 @memoize()
 def builder():
   """
   Returns a string representing the build engine (not compiler) to use.
   Possible values: 'make', 'ninja', 'xcode', 'msvs', 'scons'
   """
@@ skipping 11 matching lines @@
       # Good enough for now? Do any android bots use make?
       return 'ninja'
     elif platform() == 'ios':
       return 'xcode'
     elif IsWindows():
       return 'ninja'
     elif IsLinux():
       return 'ninja'
     elif IsMac():
       return 'ninja'
+    elif IsFreeBSD():
+      return 'ninja'
     else:
       assert False, 'Don\'t know what builder we\'re using!'